Bug 11092

Summary: Windows build busted
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch
mjs: review+
patch per hyatt adele: review+

Darin Fisher (:fishd, Google)
Reported 2006-09-29 15:34:29 PDT
Windows build busted Problems with ScrollViewWin.cpp referencing an undefined variable and Widget having undefined symbols. Patch coming up...
Attachments
patch (1.61 KB, patch)
2006-09-29 15:39 PDT, Darin Fisher (:fishd, Google) 		mjs: review+
DetailsFormatted DiffDiff
patch per hyatt (1.87 KB, patch)
2006-09-29 18:13 PDT, Darin Fisher (:fishd, Google) 		adele: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2006-09-29 15:39:54 PDT
Created attachment 10841 [details] patch This fixes the build bustage. I went for "#if !PLATFORM(MAC)" in Widget.cpp since the code should work for all other platforms. I can also move the code into WidgetWin.cpp if that is preferred.
Maciej Stachowiak
Comment 2 2006-09-29 16:39:09 PDT
Comment on attachment 10841 [details] patch r=me
Dave Hyatt
Comment 3 2006-09-29 16:42:05 PDT
Actually should just move that code into WidgetWin.cpp rather than leaving it in Widget
Darin Fisher (:fishd, Google)
Comment 4 2006-09-29 18:13:47 PDT
Created attachment 10843 [details] patch per hyatt OK, this patch simply moves the methods to WidgetWin.cpp as recommended by hyatt. I did not complete the other changes he suggested over IRC, but I didn't want to leave the tree broken, so I'm posting this simple patch.
Note You need to log in before you can comment on or make changes to this bug.