Bug 110912 – [BlackBerry] Need WebPage API for animating scroll position & zoom changes

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Andrew Lo]

Currently InputHandler and SelectionHandler set WebPagePrivate member variables to set up zoom/scroll animations.

This should be cleaned up so that WebPage has a function which simply starts a scroll/zoom adjustment animation. This also allows the web page client to also initiate scroll/zoom animations.

[Andrew Lo]

Created attachment 190368 [details]
Patch

[Rob Buis]

Comment on attachment 190368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190368&action=review

> Source/WebKit/blackberry/Api/WebPage_p.h:478
> +    void animateToScaleAndDocumentScrollPosition(double destinationZoomScale, const WebCore::FloatPoint& destinationScrollPosition, bool shouldConstrainScrollingToContentEdge = true);

You don't need the default parameter value here, this is private API.

[Rob Buis]

(In reply to comment #2)
> (From update of attachment 190368 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190368&action=review
> 
> > Source/WebKit/blackberry/Api/WebPage_p.h:478
> > +    void animateToScaleAndDocumentScrollPosition(double destinationZoomScale, const WebCore::FloatPoint& destinationScrollPosition, bool shouldConstrainScrollingToContentEdge = true);
> 
> You don't need the default parameter value here, this is private API.

Never mind this comment, we do use the private one internally.

[Rob Buis]

Comment on attachment 190368 [details]
Patch

Ok.

[WebKit Review Bot]

Comment on attachment 190368 [details]
Patch

Rejecting attachment 190368 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 190368, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ffset -4 lines).
Hunk #2 succeeded at 542 (offset -6 lines).
patching file Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
patching file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp
Hunk #1 FAILED at 801.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/16796047

[Andrew Lo]

Created attachment 190578 [details]
Patch

[Rob Buis]

Comment on attachment 190578 [details]
Patch

Retry.

[WebKit Review Bot]

Comment on attachment 190578 [details]
Patch

Clearing flags on attachment: 190578

Committed r144233: <http://trac.webkit.org/changeset/144233>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.