|Summary:||[chromium] Adapt test expectations to V8 __proto__ changes.|
|Severity:||Normal||CC:||buildbot, dglazkov, haraken, rniwa, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description mstarzinger 2013-02-26 09:22:12 PST
1) fast/dom/Window/window-custom-prototype.html [ Failure ] 2) fast/js/JSON-parse.html [ Failure ] 3) fast/js/cyclic-prototypes.html [ Failure ] ad 1) This is expected bahavior, consistent with SpiderMonkey. The test expectation is broken. Assigning 'null' to '__proto__' makes the accessor installed on Object.prototype disappear. ad 2) The result of JSON.parse() doesn't match the result we get when evaluating the same string through eval() as V8 still has special handling of the __proto__ property for object literals. ad 3) Test fully matches the WebKit expectation now and no longer fails. Expectation specific to "chrome" platform should be removed.
Comment 2 Kentaro Hara 2013-02-26 11:00:50 PST
Comment on attachment 190305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190305&action=review Don't you need to update LayoutTests/platform/chromium/TestExpectations? Has the V8 change been already landed? Or it is planned to be landed and you are trying to update these tests in advance? > LayoutTests/ChangeLog:7 > + Please describe what this patch is doing. You can copy & paste the description (https://bugs.webkit.org/show_bug.cgi?id=110887#c0) here. > LayoutTests/ChangeLog:10 > + * platform/chromium/fast/js/cyclic-prototypes-expected.txt: Maybe you can remove this file, as the result is now platform-independent.
Comment 3 WebKit Review Bot 2013-02-26 13:18:32 PST
Comment on attachment 190305 [details] Patch Attachment 190305 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16768556 New failing tests: fast/js/cyclic-prototypes.html fast/js/JSON-parse.html fast/dom/Window/window-custom-prototype.html
Comment 4 Kentaro Hara 2013-02-26 13:36:08 PST
Comment on attachment 190305 [details] Patch Marking r- for now due to the failing tests. I'd guess you need to update TestExpectations (maybe temporarily).
Comment 6 mstarzinger 2013-02-27 03:35:21 PST
(In reply to comment #2) > (From update of attachment 190305 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190305&action=review > > Don't you need to update LayoutTests/platform/chromium/TestExpectations? Done. > Has the V8 change been already landed? Or it is planned to be landed and you are trying to update these tests in advance? It's about a V8 change that has not yet made it into Chromium, but is gonna be rolled in with our roll today. This is the change: https://code.google.com/p/v8/source/detail?r=13728 > > LayoutTests/ChangeLog:7 > > + > Please describe what this patch is doing. You can copy & paste the description (https://bugs.webkit.org/show_bug.cgi?id=110887#c0) here. Done. > > LayoutTests/ChangeLog:10 > > + * platform/chromium/fast/js/cyclic-prototypes-expected.txt: > > Maybe you can remove this file, as the result is now platform-independent. Unfortunately the text is still different because of a different error message. So the text diff still fails. I adapted the description accordingly to state that.
Comment 7 Build Bot 2013-02-27 03:35:59 PST
Comment on attachment 190480 [details] Patch Attachment 190480 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16840070 New failing tests: fast/dom/Window/window-custom-prototype.html
Comment 9 Stephen Chenney 2013-02-27 05:43:58 PST
Comment on attachment 190485 [details] Patch Thanks.
Comment 10 WebKit Review Bot 2013-02-27 05:51:26 PST
Comment on attachment 190485 [details] Patch Clearing flags on attachment: 190485 Committed r144175: <http://trac.webkit.org/changeset/144175>
Comment 11 WebKit Review Bot 2013-02-27 05:51:30 PST
All reviewed patches have been landed. Closing bug.