Summary: | [chromium] Adapt test expectations to V8 __proto__ changes. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mstarzinger | ||||||||
Component: | WebCore JavaScript | Assignee: | mstarzinger | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, dglazkov, haraken, rniwa, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
mstarzinger
2013-02-26 09:22:12 PST
Created attachment 190305 [details]
Patch
Comment on attachment 190305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190305&action=review Don't you need to update LayoutTests/platform/chromium/TestExpectations? Has the V8 change been already landed? Or it is planned to be landed and you are trying to update these tests in advance? > LayoutTests/ChangeLog:7 > + Please describe what this patch is doing. You can copy & paste the description (https://bugs.webkit.org/show_bug.cgi?id=110887#c0) here. > LayoutTests/ChangeLog:10 > + * platform/chromium/fast/js/cyclic-prototypes-expected.txt: Maybe you can remove this file, as the result is now platform-independent. Comment on attachment 190305 [details] Patch Attachment 190305 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16768556 New failing tests: fast/js/cyclic-prototypes.html fast/js/JSON-parse.html fast/dom/Window/window-custom-prototype.html Comment on attachment 190305 [details]
Patch
Marking r- for now due to the failing tests. I'd guess you need to update TestExpectations (maybe temporarily).
Created attachment 190480 [details]
Patch
(In reply to comment #2) > (From update of attachment 190305 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190305&action=review > > Don't you need to update LayoutTests/platform/chromium/TestExpectations? Done. > Has the V8 change been already landed? Or it is planned to be landed and you are trying to update these tests in advance? It's about a V8 change that has not yet made it into Chromium, but is gonna be rolled in with our roll today. This is the change: https://code.google.com/p/v8/source/detail?r=13728 > > LayoutTests/ChangeLog:7 > > + > Please describe what this patch is doing. You can copy & paste the description (https://bugs.webkit.org/show_bug.cgi?id=110887#c0) here. Done. > > LayoutTests/ChangeLog:10 > > + * platform/chromium/fast/js/cyclic-prototypes-expected.txt: > > Maybe you can remove this file, as the result is now platform-independent. Unfortunately the text is still different because of a different error message. So the text diff still fails. I adapted the description accordingly to state that. Comment on attachment 190480 [details] Patch Attachment 190480 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16840070 New failing tests: fast/dom/Window/window-custom-prototype.html Created attachment 190485 [details]
Patch
Comment on attachment 190485 [details]
Patch
Thanks.
Comment on attachment 190485 [details] Patch Clearing flags on attachment: 190485 Committed r144175: <http://trac.webkit.org/changeset/144175> All reviewed patches have been landed. Closing bug. |