Bug 110784

Summary: 6% regression in intl1 page cycler on chromium-mac
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED WONTFIX    
Severity: Normal CC: eric, kling, koivisto, schenney, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109888    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2013-02-25 12:44:18 PST
6% regression in intl1 page cycler on chromium-mac
Attachments
Patch (19.85 KB, patch)
2013-02-25 12:45 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (9.70 KB, patch)
2013-02-25 16:09 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (29.91 KB, patch)
2013-02-25 23:08 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2013-02-25 12:45:38 PST
Created attachment 190107 [details] Patch
Eric Seidel (no email)
Comment 3 2013-02-25 12:46:53 PST
Comment on attachment 190107 [details] Patch Lets give it a whirl.
Adam Barth
Comment 4 2013-02-25 13:00:08 PST
Comment on attachment 190107 [details] Patch Clearing flags on attachment: 190107 Committed r143960: <http://trac.webkit.org/changeset/143960>
Adam Barth
Comment 5 2013-02-25 13:00:10 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 6 2013-02-25 13:00:28 PST
Re-opening to watch the perf graph.
Adam Barth
Comment 7 2013-02-25 14:50:33 PST
Does not appear to have healed the bot. Will wait for a couple more cycles to verify.
Adam Barth
Comment 8 2013-02-25 16:08:06 PST
I'm going to attempt a rollout of http://trac.webkit.org/changeset/143014 next. If that doesn't heal the bot, I'll roll it back in.
Adam Barth
Comment 9 2013-02-25 16:09:38 PST
Created attachment 190148 [details] Patch
Eric Seidel (no email)
Comment 10 2013-02-25 16:10:53 PST
Comment on attachment 190148 [details] Patch kling would be the best reviewer. But this looks like a proper revert.
Adam Barth
Comment 11 2013-02-25 16:14:34 PST
Comment on attachment 190148 [details] Patch Clearing flags on attachment: 190148 Committed r143983: <http://trac.webkit.org/changeset/143983>
Adam Barth
Comment 12 2013-02-25 16:14:36 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 13 2013-02-25 16:14:54 PST
Re-opening to watch the perf graph.
Adam Barth
Comment 14 2013-02-25 18:39:49 PST
Reverting the patch seems to have healed the bot, but we should wait for a few more cycles to confirm.
Adam Barth
Comment 15 2013-02-25 22:34:57 PST
The bot has not been healed.
Adam Barth
Comment 16 2013-02-25 23:08:24 PST
Created attachment 190213 [details] Patch
Eric Seidel (no email)
Comment 17 2013-02-25 23:10:22 PST
Comment on attachment 190213 [details] Patch One might argue we should roll these back in separately, but OK.
Adam Barth
Comment 18 2013-02-25 23:22:24 PST
> One might argue we should roll these back in separately, but OK. Hum... Yeah, sorry I already kicked off the script.
Adam Barth
Comment 19 2013-02-25 23:23:33 PST
Comment on attachment 190213 [details] Patch Clearing flags on attachment: 190213 Committed r144010: <http://trac.webkit.org/changeset/144010>
Adam Barth
Comment 20 2013-02-25 23:23:37 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 21 2013-02-25 23:24:15 PST
Still not fixed.
Note You need to log in before you can comment on or make changes to this bug.