Bug 110709

Summary: Reduce include graph of JSDOMBinding.h
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dgrogan, eric.carlson, esprehn+autocc, feature-media-reviews, haraken, japhet, jer.noble, jsbell, macpherson, menard, mifenton, ojan.autocc, philn, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, webkit-ews: commit-queue-
Patch for landing none

Description Andreas Kling 2013-02-24 02:41:23 PST 
We should move the WebCore::root() implementations to custom wrapper headers. This would reduce the number of headers pulled in by JSDOMBinding.h.
Comment 1 Andreas Kling 2013-02-24 02:47:05 PST 
Created attachment 189965 [details]
Patch
Comment 2 Early Warning System Bot 2013-02-24 02:54:25 PST 
Comment on attachment 189965 [details]
Patch

Attachment 189965 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16734377
Comment 3 Early Warning System Bot 2013-02-24 02:55:31 PST 
Comment on attachment 189965 [details]
Patch

Attachment 189965 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16737300
Comment 4 Andreas Kling 2013-02-24 03:15:32 PST 
Created attachment 189967 [details]
Patch for landing

...if EWS permits.
Comment 5 EFL EWS Bot 2013-02-24 03:15:37 PST 
Comment on attachment 189965 [details]
Patch

Attachment 189965 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16738279
Comment 6 WebKit Review Bot 2013-02-24 05:02:55 PST 
Comment on attachment 189967 [details]
Patch for landing

Clearing flags on attachment: 189967

Committed r143863: <http://trac.webkit.org/changeset/143863>
Comment 7 WebKit Review Bot 2013-02-24 05:03:02 PST 
All reviewed patches have been landed.  Closing bug.