Bug 110709

Summary: Reduce include graph of JSDOMBinding.h
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dgrogan, eric.carlson, esprehn+autocc, feature-media-reviews, haraken, japhet, jer.noble, jsbell, macpherson, menard, mifenton, ojan.autocc, philn, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+, webkit-ews: commit-queue-
Patch for landing none

Andreas Kling
Reported 2013-02-24 02:41:23 PST
We should move the WebCore::root() implementations to custom wrapper headers. This would reduce the number of headers pulled in by JSDOMBinding.h.
Attachments
Patch (28.77 KB, patch)
2013-02-24 02:47 PST, Andreas Kling 		koivisto: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (29.83 KB, patch)
2013-02-24 03:15 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-02-24 02:47:05 PST
Created attachment 189965 [details] Patch
Early Warning System Bot
Comment 2 2013-02-24 02:54:25 PST
Comment on attachment 189965 [details] Patch Attachment 189965 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16734377
Early Warning System Bot
Comment 3 2013-02-24 02:55:31 PST
Comment on attachment 189965 [details] Patch Attachment 189965 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16737300
Andreas Kling
Comment 4 2013-02-24 03:15:32 PST
Created attachment 189967 [details] Patch for landing ...if EWS permits.
EFL EWS Bot
Comment 5 2013-02-24 03:15:37 PST
Comment on attachment 189965 [details] Patch Attachment 189965 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16738279
WebKit Review Bot
Comment 6 2013-02-24 05:02:55 PST
Comment on attachment 189967 [details] Patch for landing Clearing flags on attachment: 189967 Committed r143863: <http://trac.webkit.org/changeset/143863>
WebKit Review Bot
Comment 7 2013-02-24 05:03:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.