Bug 110695 – REGRESSION (r143694): http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html is flakily crashing on GTK

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Zan Dobersek]

The http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html layout test is flakily crashing on GTK after r143694.
http://trac.webkit.org/changeset/143694

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=http%2Ftests%2Fsecurity%2Fcross-origin-plugin-private-browsing-toggled-allowed.html

Here's the crash log:
Crash log for DumpRenderTree (pid 11233):

...
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Debug/Programs/D'.
Program terminated with signal 11, Segmentation fault.
#0  0x00002b930b5bfde2 in JSC::Register::jsValue (this=0xffffffffffffffe8) at ../../Source/JavaScriptCore/interpreter/Register.h:122
122	        return JSValue::decode(u.value);

...

Thread 1 (Thread 0x2b9319d2fde0 (LWP 11233)):
#0  0x00002b930b5bfde2 in JSC::Register::jsValue (this=0xffffffffffffffe8) at ../../Source/JavaScriptCore/interpreter/Register.h:122
#1  0x00002b930b5bfe98 in JSC::Register::scope (this=0xffffffffffffffe8) at ../../Source/JavaScriptCore/runtime/JSScope.h:143
#2  0x00002b930b5bfe0c in JSC::ExecState::scope (this=0x0) at ../../Source/JavaScriptCore/interpreter/CallFrame.h:48
#3  0x00002b930b653f0c in JSC::ExecState::globalData (this=0x0) at ../../Source/JavaScriptCore/runtime/JSScope.h:148
#4  0x00002b930b70b7d6 in JSC::APIEntryShim::APIEntryShim (this=0x7fffa86e1020, exec=0x0, registerThread=true) at ../../Source/JavaScriptCore/API/APIShims.h:73
#5  0x00002b930c926533 in WebCore::DOMRequestState::Scope::Scope (this=0x7fffa86e1020, state=...) at ../../Source/WebCore/bindings/js/DOMRequestState.h:70
#6  0x00002b930c92502e in WebCore::IDBRequest::onSuccessInternal (this=0x3d15c10, value=...) at ../../Source/WebCore/Modules/indexeddb/IDBRequest.cpp:383
#7  0x00002b930c924ff5 in WebCore::IDBRequest::onSuccess (this=0x3d15c10) at ../../Source/WebCore/Modules/indexeddb/IDBRequest.cpp:378
#8  0x00002b930c8f2758 in WebCore::IDBDatabaseBackendImpl::deleteDatabaseFinal (this=0x3eca0b0, callbacks=...) at ../../Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1304
#9  0x00002b930c8f1163 in WebCore::IDBDatabaseBackendImpl::processPendingCalls (this=0x3eca0b0) at ../../Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1148
#10 0x00002b930c8f29f0 in WebCore::IDBDatabaseBackendImpl::close (this=0x3eca0b0, prpCallbacks=...) at ../../Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1329
#11 0x00002b930c920eb2 in WebCore::IDBOpenDBRequest::onUpgradeNeeded (this=0x3df1fc0, oldVersion=-1, prpDatabaseBackend=..., metadata=...) at ../../Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp:79
#12 0x00002b930c8f0a44 in WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform (this=0x3df1880, transaction=0x3eca3d0) at ../../Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1076
#13 0x00002b930c9288fe in WebCore::IDBTransactionBackendImpl::taskTimerFired (this=0x3eca3d0) at ../../Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp:250
#14 0x00002b930c92d779 in WebCore::Timer<WebCore::IDBTransactionBackendImpl>::fired (this=0x3eca4b8) at ../../Source/WebCore/platform/Timer.h:113
#15 0x00002b930c8c24ca in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x163b2b0) at ../../Source/WebCore/platform/ThreadTimers.cpp:129
#16 0x00002b930c8c23b7 in WebCore::ThreadTimers::sharedTimerFired () at ../../Source/WebCore/platform/ThreadTimers.cpp:105
#17 0x00002b930cac453a in WebCore::timeout_cb () at ../../Source/WebCore/platform/gtk/SharedTimerGtk.cpp:49
#18 0x00002b93108cf5ac in g_timeout_dispatch () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0
#19 0x00002b93108cd903 in g_main_dispatch () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0
#20 0x00002b93108ce4b3 in g_main_context_dispatch () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0
#21 0x00002b93108ce6a3 in g_main_context_iterate () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0
#22 0x00002b93108cead3 in g_main_loop_run () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0
#23 0x00002b930f8b8e22 in gtk_main () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libgtk-3.so.0
#24 0x000000000049ee87 in runTest (inputLine=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:770
#25 0x000000000049e53d in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:553
#26 0x00000000004a186b in main (argc=2, argv=0x7fffa86e2268) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1512

[Zan Dobersek]

http/tests/security/cross-origin-local-storage-allowed.html as well.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fcross-origin-local-storage-allowed.html%2Chttp%2Ftests%2Fsecurity%2Fcross-origin-plugin-private-browsing-toggled-allowed.html

[Martin Robinson]

CCing mpruett since he's done a lot of work on the IndexedDatabase code.

[Mario Sanchez Prada]

This is no longer failing according to the flakiness dashboard
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fsecurity%2Fcross-origin-plugin-private-browsing-toggled.html

Removed failure expectations at r159744
http://trac.webkit.org/changeset/159744