Bug 110673

Summary: RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bdakin, eric, esprehn+autocc, ojan.autocc, sam, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=259260
Bug Depends on: 111278    
Bug Blocks:    
Attachments:
Description Flags
Patch
sam: review+
Patch simon.fraser: review+

Beth Dakin
Reported 2013-02-22 18:00:02 PST
Right now, FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages like http://instagram.com/p/UrCCIVBQX3/ because they have overflow on the body. We can easily address this by calling it at the end of RenderLayer::scrollTo(). <rdar://problem/13258596>
Attachments
Patch (1.79 KB, patch)
2013-02-22 18:03 PST, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2013-03-19 14:14 PDT, Beth Dakin 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-02-22 18:03:46 PST
Created attachment 189884 [details] Patch
Beth Dakin
Comment 2 2013-02-22 18:05:27 PST
Comment on attachment 189884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189884&action=review > Source/WebCore/ChangeLog:10 > + FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages like I have removed the "like" in my local copy.
Sam Weinig
Comment 3 2013-02-22 18:12:22 PST
Comment on attachment 189884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189884&action=review > Source/WebCore/ChangeLog:6 > + RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset() > + https://bugs.webkit.org/show_bug.cgi?id=110673 > + -and corresponding- > + <rdar://problem/13258596> This is perfect. >> Source/WebCore/ChangeLog:10 >> + FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages like > > I have removed the "like" in my local copy. Like totally.
Beth Dakin
Comment 4 2013-02-22 18:15:49 PST
http://trac.webkit.org/changeset/143825
Adam Barth
Comment 5 2013-03-17 10:16:00 PDT
This patch might have caused <https://code.google.com/p/chromium/issues/detail?id=193555>. We're investigating.
Adam Barth
Comment 6 2013-03-19 00:41:34 PDT
The discussion continues on Bug 111278. The folks there confirm that this patch caused the regression.
Adam Barth
Comment 7 2013-03-19 00:43:03 PDT
This patch also lacks a regression test.
Adam Barth
Comment 8 2013-03-19 00:59:23 PDT
I rolled out this patch in http://trac.webkit.org/changeset/146185. Please feel free to re-land it once it doesn't cause a regression in the Chromium port.
Beth Dakin
Comment 9 2013-03-19 14:14:16 PDT
Created attachment 193917 [details] Patch This patch should not break Chromium.
Beth Dakin
Comment 10 2013-03-19 14:33:39 PDT
Thanks, Simon! http://trac.webkit.org/changeset/146260
Note You need to log in before you can comment on or make changes to this bug.