Bug 110668

Summary: [chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
Product: WebKit Reporter: David Dorwin <ddorwin>
Component: New BugsAssignee: David Dorwin <ddorwin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

David Dorwin
Reported 2013-02-22 17:31:01 PST
[chromium] Remove call to detach WebHelperPluginImpl's frame since it is never attached
Attachments
Patch (1.29 KB, patch)
2013-02-22 17:34 PST, David Dorwin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Dorwin
Comment 1 2013-02-22 17:34:04 PST
Created attachment 189874 [details] Patch
David Dorwin
Comment 2 2013-02-22 17:35:55 PST
abarth, as discussed - PTAL. tkent, FYI, WebPagePopupImpl might also need this change, though it just calls to an empty client.
Adam Barth
Comment 3 2013-02-22 17:42:15 PST
Comment on attachment 189874 [details] Patch Ok. For the folks reading along, we talked a bit about this issue in person. Currently our plan is for the helper plugin to participate in as little of the lifecycle as possible. If run into more of these sorts of issues, we should consider changing the design to use the shadow DOM rather than implementing the helper plugin in the WebKit layer.
WebKit Review Bot
Comment 4 2013-02-22 18:56:29 PST
Comment on attachment 189874 [details] Patch Clearing flags on attachment: 189874 Committed r143827: <http://trac.webkit.org/changeset/143827>
WebKit Review Bot
Comment 5 2013-02-22 18:56:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.