Bug 110663 – SelectorChecker should not know about SelectorCheckerFastPath.

• Component: New Bugs
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

SelectorChecker should not know about SelectorCheckerFastPath.

[Dimitri Glazkov (Google)]

Created attachment 189868 [details]
Patch

[Antti Koivisto]

Comment on attachment 189868 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189868&action=review

> Source/WebCore/css/SelectorChecker.cpp:77
> -bool SelectorChecker::matches(const CSSSelector* selector, Element* element, bool isFastCheckableSelector) const
> +bool SelectorChecker::matches(const CSSSelector* selector, Element* element) const
>  {
> -    if (isFastCheckableSelector && !element->isSVGElement()) {
> -        SelectorCheckerFastPath selectorCheckerFastPath(selector, element);
> -        if (!selectorCheckerFastPath.matchesRightmostSelector(VisitedMatchDisabled))
> -            return false;
> -        return selectorCheckerFastPath.matches();
> -    }
> -
>      PseudoId ignoreDynamicPseudo = NOPSEUDO;
>      return match(SelectorCheckingContext(selector, element, SelectorChecker::VisitedMatchDisabled), ignoreDynamicPseudo, DOMSiblingTraversalStrategy()) == SelectorMatches;
>  }

Maybe you should just remove this whole function? It does not serve much purpose anymore.

[Dimitri Glazkov (Google)]

(In reply to comment #2)
> Maybe you should just remove this whole function? It does not serve much purpose anymore.

Will do!

[Dimitri Glazkov (Google)]

Created attachment 189931 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 189931 [details]
Patch for landing

Rejecting attachment 189931 [details] from commit-queue.

New failing tests:
fast/regions/region-style-color.html
Full output: http://queues.webkit.org/results/16718889

[Dimitri Glazkov (Google)]

Created attachment 189955 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 189955 [details]
Patch for landing

Clearing flags on attachment: 189955

Committed r143858: <http://trac.webkit.org/changeset/143858>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.