Bug 110659

Summary: DFG::SpeculativeJIT::speculateNumber() should just use SpeculateDoubleOperand instead of doing its own thing
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mario, mark.lam, mhahnenberg, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2013-02-22 16:42:11 PST
This simplifies the code, and also has the effect that if speculateNumber() is called prior to someone actually using the number in a double context, then the number will already be up-converted to double and ready to go. Previously if this ever came up, the subsequent use would have to again branch to see if the value is tagged as int or tagged as double. On the other hand, if you ever did speculateNumber() and then used the value as a JSValue, this will be a slow down now. I suspect that the former (speculateNumber() and then use as number) is more likely than the latter (speculateNumber() and then use as JSValue).
Attachments
the patch (2.71 KB, patch)
2013-02-22 16:43 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-02-22 16:43:39 PST
Created attachment 189862 [details] the patch
Filip Pizlo
Comment 2 2013-02-22 17:12:51 PST
Landed in http://trac.webkit.org/changeset/143818
Note You need to log in before you can comment on or make changes to this bug.