Summary: | add to HistoryItem a way to know if its underlying CachedPage has expired | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alice Liu <alice.barraclough> | ||||||
Component: | History | Assignee: | Alice Liu <alice.barraclough> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, buildbot, ddkilzer, joepeck, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alice Liu
2013-02-22 15:31:48 PST
Created attachment 189853 [details]
not for review, just running through bots
Comment on attachment 189853 [details] not for review, just running through bots Attachment 189853 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16719342 Created attachment 189888 [details]
patch
Comment on attachment 189888 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=189888&action=review r+ with that change > Source/WebCore/history/CachedPage.cpp:56 > : m_timeStamp(currentTime()) > + , m_expiration(m_timeStamp + page->settings()->backForwardCacheExpirationInterval()) > , m_cachedMainFrame(CachedFrame::create(page->mainFrame())) Could this be m_expirationTime instead? > Source/WebCore/history/CachedPage.cpp:122 > +bool CachedPage::hasExpired() const > +{ > + return currentTime() > m_expiration; > +} If it was, this code would read more naturally. |