Bug 110651

Summary: [CSS Grid Layout] Refactor RenderStyle's grid position storage in preparation to supporting spanning
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED WONTFIX    
Severity: Normal CC: allan.jensen, eric, esprehn+autocc, macpherson, menard, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 110901    
Bug Blocks: 103314    
Attachments:
Description Flags
Proposed refactoring: Naming is really not great but start / end position won't really work. none

Julien Chaffraix
Reported 2013-02-22 15:25:20 PST
Currently RenderStyle stores a single GridPosition as we only expect grid-{row|column} to parse into a single position. However the specification allows 2 "positions" (named grid-line) so that spanning is possible. As a step to relax our syntax, let's add an indirection in what we store into RenderStyle. This will make it easier to add a second GridPosition when the parsing lands.
Attachments
Proposed refactoring: Naming is really not great but start / end position won't really work. (17.07 KB, patch)
2013-02-22 16:22 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-02-22 16:22:05 PST
Created attachment 189857 [details] Proposed refactoring: Naming is really not great but start / end position won't really work.
WebKit Review Bot
Comment 2 2013-02-25 10:10:41 PST
Comment on attachment 189857 [details] Proposed refactoring: Naming is really not great but start / end position won't really work. Clearing flags on attachment: 189857 Committed r143941: <http://trac.webkit.org/changeset/143941>
WebKit Review Bot
Comment 3 2013-02-25 10:10:44 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2013-02-26 12:47:36 PST
Re-opened since this is blocked by bug 110901
Julien Chaffraix
Comment 5 2013-02-26 12:58:09 PST
Backstory in bug 110777, basically we will need to implement grid-{start|end|before|after} if we are to accept several values for grid-{row|column}. This change made us go towards storing everything in terms of grid-{row|column}, not in terms of the 4 logical values, which is wrong in the new direction.
Note You need to log in before you can comment on or make changes to this bug.