Bug 110638

Summary: Fix the overlay play button position on android
Product: WebKit Reporter: Min Qin <qinmin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, esprehn+autocc, feature-media-reviews, jer.noble, macpherson, menard, ojan.autocc, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Min Qin
Reported 2013-02-22 13:44:29 PST
Fix the overlay play button position on android
Attachments
Patch (1.49 KB, patch)
2013-02-22 13:52 PST, Min Qin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2013-02-22 13:52:47 PST
Created attachment 189818 [details] Patch
Ojan Vafai
Comment 2 2013-02-22 14:01:22 PST
Comment on attachment 189818 [details] Patch It seems like a lot of this is duplicated with other mediaControls CSS files. Ideally we'd spend some effort reducing duplication here.
WebKit Review Bot
Comment 3 2013-02-22 14:23:08 PST
Comment on attachment 189818 [details] Patch Rejecting attachment 189818 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189818, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16720207
WebKit Review Bot
Comment 4 2013-02-22 15:23:02 PST
Comment on attachment 189818 [details] Patch Clearing flags on attachment: 189818 Committed r143809: <http://trac.webkit.org/changeset/143809>
WebKit Review Bot
Comment 5 2013-02-22 15:23:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.