Bug 110604
| Summary: | [GTK] DumpRenderTree printing always NULL when asking about WEBKIT_TOP_LEVEL | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Claudio Saavedra <csaavedra> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | mrobinson |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Claudio Saavedra
We have:
if (fontsPath.isNull())
g_error("Could not locate test fonts at %s. Is WEBKIT_TOP_LEVEL set?", fontsPath.data());
With fontsPath a CString. If CString::isNull() returns True, then CString.data() will return 0. So this *always* prints:
"Could not locate test fonts at (null). Is WEBKIT_TOP_LEVEL set?"
This makes no sense.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Martin Robinson
WebKit1 is gone.