Bug 110592

Summary: Web Inspector: [Chromium] add a browser test for frames on timeline
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Andrey Kosyakov
Reported 2013-02-22 05:08:18 PST
The existing layout tests emit artificial frame signals. We need some integration test to make sure real frame signals actually reach the inspector.
Attachments
Patch (6.81 KB, patch)
2013-02-22 05:17 PST, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2013-02-22 05:17:03 PST
Created attachment 189749 [details] Patch
Yury Semikhatsky
Comment 2 2013-02-22 05:39:25 PST
Comment on attachment 189749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189749&action=review > Source/WebKit/chromium/ChangeLog:7 > + Missing description. > Source/WebKit/chromium/src/js/Tests.js:602 > + test.assertTrue(frameCount >= 5, "Not enough frames"); Can you add a link to the test file?
Andrey Kosyakov
Comment 3 2013-02-22 05:39:33 PST
Counterpart change in chromium land: https://codereview.chromium.org/12310063/
Andrey Kosyakov
Comment 4 2013-02-22 05:56:18 PST
Committed r143725: <http://trac.webkit.org/changeset/143725>
Note You need to log in before you can comment on or make changes to this bug.