Summary: | [GTK] Stop generating UserAgentGtk.h | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gustavo, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Zan Dobersek
2013-02-22 03:04:16 PST
Created attachment 189740 [details] Patch Commit #4 from the platform-gtk branch I've set up on GitHub. https://github.com/zdobersek/webkit/commits/platform-gtk Will most likely not apply. The branch builds and works as a whole. Comment on attachment 189740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189740&action=review > Source/Platform/GNUmakefile.list.am:3 > +platform_built_sources += \ > + DerivedSources/Platform/UserAgentGtk.h > + This is generated during configuration and not by makefile rules, so I don't think it should be treated like a normal generated source. I think a better change, instead of this change is to make it so that UserAgentGtk.h isn't templatized at all. Instead we should define WEBKIT_USER_AGENT_MAJOR_VERSION in the autotoolsconfig.h header. Making this a standalone bug. (In reply to comment #2) > Instead we should define WEBKIT_USER_AGENT_MAJOR_VERSION in the autotoolsconfig.h header. Created attachment 189970 [details]
Patch
Comment on attachment 189970 [details]
Patch
Thanks!
Comment on attachment 189970 [details] Patch Clearing flags on attachment: 189970 Committed r143875: <http://trac.webkit.org/changeset/143875> All reviewed patches have been landed. Closing bug. |