Bug 110582

Summary: [GTK] Stop generating UserAgentGtk.h
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Zan Dobersek 2013-02-22 03:04:16 PST
[GTK] Generate UserAgentGtk.h into DerivedSources/Platform
Comment 1 Zan Dobersek 2013-02-22 03:46:50 PST
Created attachment 189740 [details]
Patch

Commit #4 from the platform-gtk branch I've set up on GitHub.
https://github.com/zdobersek/webkit/commits/platform-gtk

Will most likely not apply. The branch builds and works as a whole.
Comment 2 Martin Robinson 2013-02-22 12:28:31 PST
Comment on attachment 189740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189740&action=review

> Source/Platform/GNUmakefile.list.am:3
> +platform_built_sources += \
> +	DerivedSources/Platform/UserAgentGtk.h
> +

This is generated during configuration and not by makefile rules, so I don't think it should be treated like a normal generated source. I think a better change, instead of this change is to make it so that UserAgentGtk.h isn't templatized at all. Instead we should define WEBKIT_USER_AGENT_MAJOR_VERSION in the autotoolsconfig.h header.
Comment 3 Zan Dobersek 2013-02-24 02:47:32 PST
Making this a standalone bug.
Comment 4 Zan Dobersek 2013-02-24 04:02:32 PST
(In reply to comment #2)
> Instead we should define WEBKIT_USER_AGENT_MAJOR_VERSION in the autotoolsconfig.h header.
Comment 5 Zan Dobersek 2013-02-24 04:16:15 PST
Created attachment 189970 [details]
Patch
Comment 6 Martin Robinson 2013-02-24 07:39:43 PST
Comment on attachment 189970 [details]
Patch

Thanks!
Comment 7 Zan Dobersek 2013-02-24 11:03:02 PST
Comment on attachment 189970 [details]
Patch

Clearing flags on attachment: 189970

Committed r143875: <http://trac.webkit.org/changeset/143875>
Comment 8 Zan Dobersek 2013-02-24 11:03:07 PST
All reviewed patches have been landed.  Closing bug.