Bug 110582

Summary: [GTK] Stop generating UserAgentGtk.h
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2013-02-22 03:04:16 PST
[GTK] Generate UserAgentGtk.h into DerivedSources/Platform
Attachments
Patch (7.77 KB, patch)
2013-02-22 03:46 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (9.67 KB, patch)
2013-02-24 04:16 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-02-22 03:46:50 PST
Created attachment 189740 [details] Patch Commit #4 from the platform-gtk branch I've set up on GitHub. https://github.com/zdobersek/webkit/commits/platform-gtk Will most likely not apply. The branch builds and works as a whole.
Martin Robinson
Comment 2 2013-02-22 12:28:31 PST
Comment on attachment 189740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189740&action=review > Source/Platform/GNUmakefile.list.am:3 > +platform_built_sources += \ > + DerivedSources/Platform/UserAgentGtk.h > + This is generated during configuration and not by makefile rules, so I don't think it should be treated like a normal generated source. I think a better change, instead of this change is to make it so that UserAgentGtk.h isn't templatized at all. Instead we should define WEBKIT_USER_AGENT_MAJOR_VERSION in the autotoolsconfig.h header.
Zan Dobersek
Comment 3 2013-02-24 02:47:32 PST
Making this a standalone bug.
Zan Dobersek
Comment 4 2013-02-24 04:02:32 PST
(In reply to comment #2) > Instead we should define WEBKIT_USER_AGENT_MAJOR_VERSION in the autotoolsconfig.h header.
Zan Dobersek
Comment 5 2013-02-24 04:16:15 PST
Created attachment 189970 [details] Patch
Martin Robinson
Comment 6 2013-02-24 07:39:43 PST
Comment on attachment 189970 [details] Patch Thanks!
Zan Dobersek
Comment 7 2013-02-24 11:03:02 PST
Comment on attachment 189970 [details] Patch Clearing flags on attachment: 189970 Committed r143875: <http://trac.webkit.org/changeset/143875>
Zan Dobersek
Comment 8 2013-02-24 11:03:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.