Bug 110553

Summary: [V8] Add comments to checkTypeOrDieTrying()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, rniwa, simon.fraser, tsepez, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2013-02-21 21:53:13 PST
It is mysterious how the check is helpful.
Attachments
Patch (2.53 KB, patch)
2013-02-21 21:54 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (17.10 KB, patch)
2013-02-22 11:51 PST, Thomas Sepez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-21 21:54:33 PST
Created attachment 189679 [details] Patch
WebKit Review Bot
Comment 2 2013-02-22 08:55:49 PST
Comment on attachment 189679 [details] Patch Clearing flags on attachment: 189679 Committed r143737: <http://trac.webkit.org/changeset/143737>
WebKit Review Bot
Comment 3 2013-02-22 08:55:52 PST
All reviewed patches have been landed. Closing bug.
Thomas Sepez
Comment 5 2013-02-22 11:26:51 PST
Kentaro, you'll have to run WebKit/Tools/Scripts/run-bindings-tests --reset-results to rebaseline these results.
Thomas Sepez
Comment 6 2013-02-22 11:51:00 PST
Created attachment 189802 [details] Patch Here's a quick patch to rebaseline those results.
Kentaro Hara
Comment 7 2013-02-22 12:26:55 PST
Sorry for the delayed response. It's fixed in r143771 by rniwa. Thanks!
Ryosuke Niwa
Comment 8 2013-02-22 12:27:50 PST
Rebaseline the tests in http://trac.webkit.org/changeset/143771.
Note You need to log in before you can comment on or make changes to this bug.