Bug 110541

Summary: Better sizing model for Snapshotted plugins
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dean Jackson
Reported 2013-02-21 18:21:45 PST
At the moment we have a slightly confusing model of deciding how to tell the shadow root of a snapshotted plugin how big it is. Clean this up a little. Unfortunately the sizes are still somewhat arbitrary, but we can address this later.
Attachments
Patch (9.92 KB, patch)
2013-02-21 18:29 PST, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-02-21 18:29:39 PST
Created attachment 189658 [details] Patch
Jon Lee
Comment 2 2013-02-21 18:47:18 PST
Comment on attachment 189658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189658&action=review > Source/WebCore/html/HTMLPlugInImageElement.cpp:426 > + if (!width || !height || (width <= sizingTinyDimensionThreshold || height <= sizingTinyDimensionThreshold)) { By changing the logic to only require one of the dimensions being less than the threshold, there's no need for the !width and !height checks.
Dean Jackson
Comment 3 2013-02-21 18:51:32 PST
Committed r143680: <http://trac.webkit.org/changeset/143680>
Note You need to log in before you can comment on or make changes to this bug.