Bug 110539

Summary: 25-30% regression in V8 RayTrace test in 32 bit builds with JIT disabled
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2013-02-21 18:03:39 PST
A regression of 25-30% was found in iOS builds when running JavaScript with just the interpreter running V8 RayTrace. The problem has been tracked to a change made in r129713 <http://trac.webkit.org/changeset/129713> in llint/LowLevelInterpreter32_64.asm. When looking up a pointer in the JSGlobalObject::m_specialPointers array on 32 bit builds, we should use a scale of 4 instead of the 8 introduced in that patch. This is being tracked in <rdar://problem/13102630>.
Attachments
Patch (1.43 KB, patch)
2013-02-21 18:07 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-02-21 18:07:14 PST
Created attachment 189655 [details] Patch This patch has already been reviewed in person.
Michael Saboff
Comment 2 2013-02-21 18:11:47 PST
Committed r143677: <http://trac.webkit.org/changeset/143677>
Note You need to log in before you can comment on or make changes to this bug.