Bug 110531

Summary: Remove browser patching mechanism for handling javascript dialogs in chromium port
Product: WebKit Reporter: Ken Kania <kkania>
Component: Web Inspector (Deprecated)Assignee: Ken Kania <kkania>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, dglazkov, fishd, jamesr, keishi, loislo, pfeldman, pmuellr, tkent+wkapi, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Ken Kania
Reported 2013-02-21 16:37:58 PST
Page.handleJavaScriptDialog is now handled in the browser process for the chromium port. We can remove the old message patching technique.
Attachments
Patch (4.20 KB, patch)
2013-02-21 16:40 PST, Ken Kania 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ken Kania
Comment 1 2013-02-21 16:40:15 PST
Created attachment 189636 [details] Patch
WebKit Review Bot
Comment 2 2013-02-21 16:43:17 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2013-02-25 08:56:38 PST
Comment on attachment 189636 [details] Patch Rejecting attachment 189636 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189636, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://queues.webkit.org/results/16746387
WebKit Review Bot
Comment 4 2013-02-25 16:52:33 PST
Comment on attachment 189636 [details] Patch Clearing flags on attachment: 189636 Committed r143987: <http://trac.webkit.org/changeset/143987>
WebKit Review Bot
Comment 5 2013-02-25 16:52:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.