Bug 110510

Summary:

Nodes should not have attributes property

Product:

WebKit

Reporter:

Erik Arvidsson <arv>

Component:

DOM

Assignee:

Erik Arvidsson <arv>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cmarcelo, dglazkov, esprehn+autocc, ojan.autocc, webkit.review.bot

Priority:

Keywords:

WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://dom.spec.whatwg.org/#node

Attachments:

Description	Flags
Patch	none
Patch	none

Erik Arvidsson

Reported 2013-02-21 13:35:13 PST

https://code.google.com/p/chromium/source/search?q=file%3Anode%5C.idl+attributes&origq=file%3Anode%5C.idl+attributes&btnG=Search+Trunk

Attachments
Patch (4.80 KB, patch) 2013-02-21 14:11 PST, Erik Arvidsson	no flags	Details Formatted Diff Diff
Patch (12.83 KB, patch) 2013-02-21 15:14 PST, Erik Arvidsson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Erik Arvidsson

Comment 1 2013-02-21 13:37:15 PST

Also, hasAttributes is in the wrong idl file. The following should all be moved to Element.idl attributes hasAttributes

Erik Arvidsson

Comment 2 2013-02-21 14:11:06 PST

Created attachment 189599 [details] Patch

Adam Barth

Comment 3 2013-02-21 14:50:14 PST

Comment on attachment 189599 [details] Patch Are we worried about the compatibility impact of this change?

WebKit Review Bot

Comment 4 2013-02-21 14:50:49 PST

Comment on attachment 189599 [details] Patch Attachment 189599 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16695354 New failing tests: fast/dom/Node/initial-values.html

Erik Arvidsson

Comment 5 2013-02-21 15:07:35 PST

(In reply to comment #3) > (From update of attachment 189599 [details]) > Are we worried about the compatibility impact of this change? Not really. attributes returned null on non Elements before and now it will return undefined. This part I'm completely confident that it is safe. It is possible that someone has code out there that calls hasAttributes() on an Attr, Text, DocumentFragment or Document but it unlikely and wrong. I could definitely split this into two patches just to make things easier to rollback in case of unforeseen issues.

Erik Arvidsson

Comment 6 2013-02-21 15:14:01 PST

Created attachment 189610 [details] Patch

Adam Barth

Comment 7 2013-02-21 15:52:01 PST

Comment on attachment 189610 [details] Patch Ok.

WebKit Review Bot

Comment 8 2013-02-21 16:29:03 PST

Comment on attachment 189610 [details] Patch Clearing flags on attachment: 189610 Committed r143663: <http://trac.webkit.org/changeset/143663>

WebKit Review Bot

Comment 9 2013-02-21 16:29:06 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.