Bug 110497

Summary: WEBGL_compressed_texture_pvrtc needs implementation
Product: WebKit Reporter: Remi Arnaud <Remi.Arnaud>
Component: WebGLAssignee: Brandon Jones <bajones>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, bajones, dino, esprehn+autocc, gman, gyuyoung.kim, haraken, japhet, kbr, ojan.autocc, rakuco, webkit.review.bot, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_pvrtc/
Bug Depends on:    
Bug Blocks: 127023    
Attachments:
Description Flags
Patch
none
Patch none

Remi Arnaud
Reported 2013-02-21 12:11:37 PST
WEBGL_compressed_texture_pvrtc (see URL) is in Draft stage, and is awaiting implementation to enable the community to review the extension. WEBGL_compressed_texture_pvrtc in necessary to take advantage of specific hardware texture compression, and is used to enable content to fit in the device GPU memory, as well as optimizing for speed (smaller transfer, zero decoding time). This extension is similar to WEBGL_compressed_texture_s3tc, already implemented, that covers a lot of devices, but unfortunately is not available on all devices. See also bug https://bugs.webkit.org/show_bug.cgi?id=110496
Attachments
Patch (49.64 KB, patch)
2013-03-19 11:43 PDT, Brandon Jones 		no flags
DetailsFormatted DiffDiff
Patch (49.72 KB, patch)
2013-03-25 13:40 PDT, Brandon Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brandon Jones
Comment 1 2013-02-21 14:38:43 PST
I'll take this one as well
Brandon Jones
Comment 2 2013-03-19 11:43:55 PDT
Created attachment 193880 [details] Patch
Kenneth Russell
Comment 3 2013-03-22 16:51:51 PDT
Comment on attachment 193880 [details] Patch Nice work. r=me
Kenneth Russell
Comment 4 2013-03-22 17:19:39 PDT
Comment on attachment 193880 [details] Patch I hope this still applies...
WebKit Review Bot
Comment 5 2013-03-22 17:27:30 PDT
Comment on attachment 193880 [details] Patch Rejecting attachment 193880 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 193880, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: cceeded at 1 with fuzz 3. patching file LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-pvrtc-expected.txt patching file LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html patching file LayoutTests/webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Kenneth Russell']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://webkit-commit-queue.appspot.com/results/17211665
Brandon Jones
Comment 6 2013-03-25 13:40:23 PDT
Created attachment 194915 [details] Patch
Brandon Jones
Comment 7 2013-03-25 13:41:06 PDT
Comment on attachment 194915 [details] Patch Patch rebased, should apply cleanly now
Kenneth Russell
Comment 8 2013-03-25 15:46:27 PDT
OK, this looks good.
WebKit Review Bot
Comment 9 2013-03-25 15:54:05 PDT
Comment on attachment 194915 [details] Patch Clearing flags on attachment: 194915 Committed r146820: <http://trac.webkit.org/changeset/146820>
WebKit Review Bot
Comment 10 2013-03-25 15:54:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.