Bug 110496 – WEBGL_compressed_texture_atc needs implementation

• Component: WebGL
• Status: RESOLVED FIXED

[Remi Arnaud]

WEBGL_compressed_texture_atc (see URL) is in Draft stage, and is awaiting implementation to enable the community to review the extension.

WEBGL_compressed_texture_atc in necessary to take advantage of specific hardware texture compression, and is used to enable content to fit in the device GPU memory, as well as optimizing for speed (smaller transfer, zero decoding time). This extension is similar to WEBGL_compressed_texture_s3tc, already implemented, that covers a lot of devices, but unfortunately is not available on all devices.

[Remi Arnaud]

See also bug https://bugs.webkit.org/show_bug.cgi?id=110497

[Brandon Jones]

I can take this

[Brandon Jones]

Created attachment 190805 [details]
Patch

[Kenneth Russell]

Comment on attachment 190805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190805&action=review

The code looks OK but the patch needs to be rebaselined to pass the EWS. Also there's a problem with the layout test.

> LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-atc.html:1
> +<!--

This isn't right -- the real test should go under resources/webgl_test_files/ and this should just be a wrapper. Please use the webgl/generate-webgl-tests.py script to generate this (you'll need to ignore the other changes it makes to your tree). Also, watch out for those leading non-ASCII characters -- not sure where those are coming from.

[Brandon Jones]

Created attachment 191000 [details]
Patch

[WebKit Review Bot]

Attachment 191000 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-atc-expected.txt', u'LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-atc.html', u'LayoutTests/webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-atc.html', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/WebGLCompressedTextureATC.cpp', u'Source/WebCore/html/canvas/WebGLCompressedTextureATC.h', u'Source/WebCore/html/canvas/WebGLCompressedTextureATC.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/platform/graphics/Extensions3D.h']" exit_code: 1
Source/WebCore/platform/graphics/Extensions3D.h:146:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:147:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:148:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 191000 [details]
Patch

Attachment 191000 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16662208

[WebKit Review Bot]

Comment on attachment 191000 [details]
Patch

Attachment 191000 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16849278

[Brandon Jones]

Created attachment 191021 [details]
Patch

[WebKit Review Bot]

Attachment 191021 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-atc-expected.txt', u'LayoutTests/webgl/conformance/extensions/webgl-compressed-texture-atc.html', u'LayoutTests/webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-atc.html', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp', u'Source/WebCore/html/canvas/WebGLCompressedTextureATC.cpp', u'Source/WebCore/html/canvas/WebGLCompressedTextureATC.h', u'Source/WebCore/html/canvas/WebGLCompressedTextureATC.idl', u'Source/WebCore/html/canvas/WebGLExtension.h', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.h', u'Source/WebCore/platform/graphics/Extensions3D.h']" exit_code: 1
Source/WebCore/platform/graphics/Extensions3D.h:146:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:147:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/Extensions3D.h:148:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Russell]

Comment on attachment 191021 [details]
Patch

Looks great. r=me

[WebKit Review Bot]

Comment on attachment 191021 [details]
Patch

Rejecting attachment 191021 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 191021, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
rce/WebKit/chromium/webkit/media/crypto/ppapi/cdm --revision 181763 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
57>At revision 181763.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/16867079

[Brandon Jones]

Created attachment 191305 [details]
Patch

[WebKit Review Bot]

Comment on attachment 191305 [details]
Patch

Clearing flags on attachment: 191305

Committed r144723: <http://trac.webkit.org/changeset/144723>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.