Summary: | Plug-in snapshotting code always accepts first snapshot | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | Plug-ins | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | esprehn+autocc, ojan.autocc, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2013-02-21 11:58:31 PST
Created attachment 189570 [details]
Patch
Comment on attachment 189570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189570&action=review > Source/WebKit2/WebProcess/Plugins/PluginView.cpp:74 > -static const unsigned maximumSnapshotRetries = 60; > +static const unsigned maximumSnapshotRetries = 4; I don't see an explanation for this change. > Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1609 > + m_pluginElement->setDisplayState(HTMLPlugInElement::DisplayingSnapshot); When does the tear-down happen now? Comment on attachment 189570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189570&action=review >> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:74 >> +static const unsigned maximumSnapshotRetries = 4; > > I don't see an explanation for this change. I will add this to the changelog: I also reduced the number of snapshot attempts we will make before giving up. We don't want to sit around for 66 seconds displaying nothing. >> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1609 >> + m_pluginElement->setDisplayState(HTMLPlugInElement::DisplayingSnapshot); > > When does the tear-down happen now? Oh, that happens anyway, because as soon as I set the displayState it will swap renderers. It was the existing renderer that had the Widget, and the reference to the PluginView, and so we tear things down in the destructor. Committed r143650: <http://trac.webkit.org/changeset/143650> |