Bug 110462

Summary: Make SpellCheckRequest's constructor private
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: HTML EditingAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: laszlo.gombos, mifenton, morrita, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch tonikitoo: review+

Grzegorz Czajkowski
Reported 2013-02-21 06:03:47 PST
It's no need to expose SpellCheckRequest's constructor. There is SpellCheckRequest::create() method which is responsible for creating SpellCheckRequest object.
Attachments
proposed patch (2.06 KB, patch)
2013-02-21 06:04 PST, Grzegorz Czajkowski 		tonikitoo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2013-02-21 06:04:29 PST
Created attachment 189515 [details] proposed patch
Antonio Gomes
Comment 2 2013-02-21 06:06:16 PST
Comment on attachment 189515 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=189515&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=XXXXXXXXXXXXXXXX Does the commit-queue fill it up for you?
WebKit Review Bot
Comment 3 2013-02-21 06:07:07 PST
Attachment 189515 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/editing/SpellChecker.h']" exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Grzegorz Czajkowski
Comment 4 2013-02-21 06:08:19 PST
(In reply to comment #2) > (From update of attachment 189515 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189515&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=XXXXXXXXXXXXXXXX > > Does the commit-queue fill it up for you? Sorry, it's my art :) I will fix it before landing.
Grzegorz Czajkowski
Comment 5 2013-02-21 06:21:36 PST
Committed r143596: <http://trac.webkit.org/changeset/143596>
Note You need to log in before you can comment on or make changes to this bug.