Bug 110421

Summary:

[WinCE] Link error - missing method createDragImageFromImage()

Product:

WebKit

Reporter:

Mark Salisbury <mark.salisbury>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

glenn, mark.salisbury, paroga

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
Proposed fix	none

Description Mark Salisbury 2013-02-20 17:49:43 PST

I see a link error compiling for WinCE.  ClipboardWin.cpp expects to be able to call createDragImageFromImage() but it is not implemented for WinCE (today WinCE does not use Cairo or Core Graphics).

Comment 1 Mark Salisbury 2013-02-20 18:04:16 PST

Created attachment 189435 [details]
Proposed fix

Comment 2 Mark Salisbury 2013-02-26 09:31:03 PST

Thoughts?

Comment 3 Patrick R. Gansterer 2013-04-06 02:30:09 PDT

Committed r147835: <http://trac.webkit.org/changeset/147835>

Comment 4 Glenn Adams 2013-04-14 17:03:52 PDT

(In reply to comment #3)
> Committed r147835: <http://trac.webkit.org/changeset/147835>

I notice that this patch was committed without any review. Or if there was a review, it isn't marked anywhere. That's a NO NO!

Comment 5 Glenn Adams 2013-04-14 17:05:53 PDT

(In reply to comment #4)
> (In reply to comment #3)
> > Committed r147835: <http://trac.webkit.org/changeset/147835>
> 
> I notice that this patch was committed without any review. Or if there was a review, it isn't marked anywhere. That's a NO NO!

That is, either there should be a "Reviewed by" line or an "Unreviewed" line in the ChangeLog.

Comment 6 Mark Salisbury 2013-04-15 08:24:46 PDT

Glenn - thank you for providing feedback.

I'll be sure to create patches that have "Unreviewed", "Reviewed by NOBODY (OOPS!)", or "Reviewed by <intended reviewer>" in the ChangeLog.

Comment 7 Rob Buis 2013-05-10 11:51:22 PDT

Comment on attachment 189435 [details]
Proposed fix

Get out of review queue, patch has landed by now.