Bug 110416 – [CMake] VS 2008 fails to link WebCore.lib because it is too large

• Component: Platform
• Status: RESOLVED WONTFIX

[Mark Salisbury]

This is a bug in Visual Studio's linker but it can be worked around with a link flag.

This error looks like "NK1106: invalid file or disk full: cannot seek to ...."

See https://connect.microsoft.com/VisualStudio/feedback/details/521439/link-failure-lnk1106-on-ltcg-for-a-static-library for more info.

[Mark Salisbury]

Created attachment 189433 [details]
Proposed fix

[WebKit Review Bot]

Attachment 189433 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/PlatformWinCE.cmake']" exit_code: 1
Source/WebCore/PlatformWinCE.cmake:135:  Use lowercase command "if"  [command/lowercase] [5]
Source/WebCore/PlatformWinCE.cmake:139:  Use lowercase command "list"  [command/lowercase] [5]
Source/WebCore/PlatformWinCE.cmake:140:  Use lowercase command "endif"  [command/lowercase] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Salisbury]

Created attachment 189550 [details]
Proposed fix

This patch addresses style issues found in the first patch

[WebKit Review Bot]

Attachment 189550 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/PlatformWinCE.cmake']" exit_code: 1
Source/WebCore/PlatformWinCE.cmake:139:  No space between command "list" and its parentheses, should be "list("  [whitespace/parentheses] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Salisbury]

Created attachment 189554 [details]
Proposed fix

another style fix... should be the last

[Patrick R. Gansterer]

Comment on attachment 189554 [details]
Proposed fix

is it really necessary to add this ugly variables?
Isn't it possible to set tis LINK_FLAGS globally?

[Mark Salisbury]

Q1: Yes, unfortunately.
Q2: I don't think we want to reserve space for all libraries globally, just webcore as it's the big beast.

I initially wanted to only change Source/WebCore/PlatformWinCE.cmake, but the pattern for all other libraries is to create a variable named <library name>_LINK_FLAGS, so that the common cmake file could set link flags but at the same time allow platform specific link flags to be specified.

I think the other reason that I had to add code to WebCore/CMakeLists.txt to add the link flags is that the link flags have to be added after the "add_library" command but the platform file must be included before the "add_library" command.

I could make my changes smaller by not providing support for setting link flags if building webcore as SHARED_CORE (dll).  I did some experimenting with building webcore as a dll and found other problems that prevented building webcore as a .dll (believe those were dependencies on webkit and lack of exports).

[Mark Salisbury]

Thoughts?

[Andreas Kling]

Comment on attachment 189554 [details]
Proposed fix

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.

[Ahmad Saleem]

VS2008 is EOL (End of Life) - https://learn.microsoft.com/en-us/lifecycle/products/visual-studio-2008

I think we wouldn't have these issues with newer MSVC plus 'PlatformWinCE.cmake' don't exist anymore.

Marking this as 'RESOLVED WONTFIX' and CCing 'Fuji' for his visibility.