Bug 110401

Summary: [chromium] http/tests/security/feed-urls-from-remote.html times out after bug 109995
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Severity: Normal CC: abarth, dglazkov, japhet, jochen, schenney, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109995    
Description Flags
Mostly for the EWSes to munch on. webkit.review.bot: commit-queue-

Description Eric Seidel (no email) 2013-02-20 16:09:28 PST
DocumentLoader should think it's loading while the parser is still active
Comment 1 Eric Seidel (no email) 2013-02-20 16:36:45 PST
Created attachment 189410 [details]
Mostly for the EWSes to munch on.
Comment 2 WebKit Review Bot 2013-02-20 18:18:24 PST
Comment on attachment 189410 [details]
Mostly for the EWSes to munch on.

Attachment 189410 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16646691

New failing tests:
Comment 3 Eric Seidel (no email) 2013-02-21 09:00:45 PST
Looking at the failure now.
Comment 4 Eric Seidel (no email) 2013-02-21 12:39:07 PST
Reduction of the hang:

<iframe src="feed.html" onLoad="testRunner.notifyDone()"></iframe>

<a id="myFeed">The feed:// URL</a>
    var myFeed = document.getElementById("myFeed");
    myFeed.href = "feed://" + document.location.port + "/security/resources/feed.xml";
    var evt = document.createEvent("MouseEvents");
    evt.initMouseEvent("click", true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);

<empty> (can be anything)
Comment 5 Eric Seidel (no email) 2013-02-21 12:39:45 PST
I'm not sure if the feed: part is important. But a data url seemed to not cause the hang, and invalid urls also failed to hang.
Comment 6 Eric Seidel (no email) 2013-02-21 13:10:56 PST
Actually, that reduction times out even w/o my change.  However, adding back the setCustomPolicyDelegate calls, makes it complete again!
Comment 7 Eric Seidel (no email) 2013-02-21 13:52:34 PST
So at first glance, this change seems to change behavior of the policyDelegate codepath in the loader, causing this one test which depended on this to fail. :)

It's not clear yet if this is just a bug in Chromium's DRT, relating to this quirk in the policyDelgate codepath, or if this could be a real bug for the policyDelegate codepath (which would only affect Mac).

Building Mac now.
Comment 8 Eric Seidel (no email) 2013-02-21 15:20:25 PST
More context:

<iframe src="resource.html" onLoad="testRunner.notifyDone()"></iframe>

location.href = "feed://" + document.location.port + "/security/resources/feed.xml";

Hangs Chromium DRT, but does not hang Mac (w/o the patch).

Changing feed: to http: does not hang Chromium DRT (with or w/o the patch!)
Comment 9 Eric Seidel (no email) 2013-02-21 15:54:14 PST
Comment on attachment 189410 [details]
Mostly for the EWSes to munch on.

I'm going to complete this in bug 109995 and leave this for solving the chromium DRT oddity (if we ever chose to).  Most of the other tests in this directory are already marked Wontfix it seems.
Comment 10 Eric Seidel (no email) 2013-02-21 22:55:46 PST
bug 109995 also broke Mac WK1, seen in bug 110554.