Bug 110300

Summary: Remove unnecessary includes for Platform.h from headers
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, dino, eric.carlson, eric, feature-media-reviews, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
1st try none

Laszlo Gombos
Reported 2013-02-19 21:45:19 PST
In almost most cases config.h includes wtf/Platform.h and config.h gets included as the first header in almost all compilation unit, so in almost all cases there is no need to include wtf/Platform.h explicitly in header files.
Attachments
1st try (4.80 KB, patch)
2013-02-19 21:51 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-02-19 21:51:45 PST
Created attachment 189237 [details] 1st try
Eric Seidel (no email)
Comment 2 2013-02-20 12:45:48 PST
Comment on attachment 189237 [details] 1st try Yeah, I believe the style is that Platform.h is part of config.h which is required before any other includes in a cpp file. That said, it feels a bit odd to use PLATFORM(MAC) in a header w/o having Platform.h included.
WebKit Review Bot
Comment 3 2013-02-20 13:47:39 PST
Comment on attachment 189237 [details] 1st try Clearing flags on attachment: 189237 Committed r143499: <http://trac.webkit.org/changeset/143499>
WebKit Review Bot
Comment 4 2013-02-20 13:47:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.