|Summary:||Remove unnecessary includes for Platform.h from headers|
|Product:||WebKit||Reporter:||Laszlo Gombos <laszlo.gombos>|
|Severity:||Normal||CC:||ap, benjamin, dino, eric.carlson, eric, feature-media-reviews, webkit.review.bot, zherczeg|
|Version:||528+ (Nightly build)|
Description Laszlo Gombos 2013-02-19 21:45:19 PST
In almost most cases config.h includes wtf/Platform.h and config.h gets included as the first header in almost all compilation unit, so in almost all cases there is no need to include wtf/Platform.h explicitly in header files.
Comment 2 Eric Seidel (no email) 2013-02-20 12:45:48 PST
Comment on attachment 189237 [details] 1st try Yeah, I believe the style is that Platform.h is part of config.h which is required before any other includes in a cpp file. That said, it feels a bit odd to use PLATFORM(MAC) in a header w/o having Platform.h included.
Comment 3 WebKit Review Bot 2013-02-20 13:47:39 PST
Comment on attachment 189237 [details] 1st try Clearing flags on attachment: 189237 Committed r143499: <http://trac.webkit.org/changeset/143499>
Comment 4 WebKit Review Bot 2013-02-20 13:47:42 PST
All reviewed patches have been landed. Closing bug.