Bug 110233

Summary: HeapBlock::destroy should issue warning if result is unused
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2013-02-19 09:39:01 PST
To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy, we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.
Attachments
Patch (1.35 KB, patch)
2013-02-19 10:22 PST, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-02-19 10:22:43 PST
Created attachment 189109 [details] Patch
WebKit Review Bot
Comment 2 2013-02-19 10:41:48 PST
Comment on attachment 189109 [details] Patch Clearing flags on attachment: 189109 Committed r143354: <http://trac.webkit.org/changeset/143354>
WebKit Review Bot
Comment 3 2013-02-19 10:41:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.