Bug 110232

Summary: Web Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into ResourceTreeModel
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 109572    
Attachments:
Description Flags
Patch vsevik: review+

Description Alexander Pavlov (apavlov) 2013-02-19 09:06:36 PST
This is necessary to keep track of all potential storages in the inspected page.
Comment 1 Alexander Pavlov (apavlov) 2013-02-20 01:40:25 PST
Created attachment 189265 [details]
Patch
Comment 2 Yury Semikhatsky 2013-02-20 02:00:37 PST
Comment on attachment 189265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189265&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:139
> +        if (!this._securityOriginFrameCount[securityOrigin])

When does this happen?

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:160
> +                removeOriginForFrame.call(this, frame.childFrames[i]);

this.removeOriginForFrame(frame.childFrames[i]); ?
Comment 3 Vsevolod Vlasov 2013-02-20 02:13:51 PST
Comment on attachment 189265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189265&action=review

> LayoutTests/http/tests/inspector/resource-tree/resource-tree-events-expected.txt:10
> +    SecurityOriginAdded : http://frame/child2.html

Let's add a test for navigation of already existing frame.
Comment 4 Vsevolod Vlasov 2013-02-20 02:19:21 PST
Comment on attachment 189265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189265&action=review

>> Source/WebCore/inspector/front-end/ResourceTreeModel.js:139
>> +        if (!this._securityOriginFrameCount[securityOrigin])
> 
> When does this happen?

I would put console.assert instead.
Comment 5 Alexander Pavlov (apavlov) 2013-02-20 03:03:14 PST
Committed r143443: <http://trac.webkit.org/changeset/143443>