Bug 110222

Summary: [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, obzhirov
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2013-02-19 07:18:02 PST
The fast/events/platform-wheelevent-with-delta-zero-crash.html layout test is crashing since it's been introduced in r143303. http://trac.webkit.org/changeset/143303 Seems as the implementation of mouseScrollByCallback must be expanded. Crash log for DumpRenderTree (pid 11006): ... Thread 1 (Thread 0x2b83b5d8ede0 (LWP 11006)): #0 0x00002b83aded2475 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x00002b83aded56f0 in abort () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x00002b83ac95c43c in g_assertion_message () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0 #3 0x00000000004a080c in mouseScrollByCallback (context=0x2b83fa2c3108, function=0x2b83fa80fcf0, thisObject=0x2b83fa80f3b0, argumentCount=2, arguments=0x7fff21904aa8, exception=0x7fff21904b48) at ../../Tools/DumpRenderTree/gtk/EventSender.cpp:471 #4 0x00002b83a668c3c0 in JSC::JSCallbackFunction::call (exec=0x2b83fa2c3108) at ../../Source/JavaScriptCore/API/JSCallbackFunction.cpp:74 #5 0x00002b83a68f0bec in JSC::LLInt::handleHostCall (execCallee=0x2b83fa2c3108, pc=0x1a2c248, callee=..., kind=JSC::CodeForCall) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1364 #6 0x00002b83a68f3adb in JSC::LLInt::setUpCall (execCallee=0x2b83fa2c3108, pc=0x1a2c248, kind=JSC::CodeForCall, calleeAsValue=..., callLinkInfo=0x1a2c6f8) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1408 #7 0x00002b83a68f404a in JSC::LLInt::genericCall (exec=0x2b83fa2c30a0, pc=0x1a2c248, kind=JSC::CodeForCall) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1464 #8 0x00002b83a68f1159 in JSC::LLInt::llint_slow_path_call (exec=0x2b83fa2c30a0, pc=0x1a2c248) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1470 #9 0x00002b83a68f83af in llint_op_call () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0 #10 0x00002b83fa2c3060 in ?? () #11 0x0000000000889c00 in ?? () #12 0x00007fff21904f30 in ?? () #13 0x00002b83a689d247 in JSC::JSStack::installTrapsAfterFrame (this=0x0, frame=0x0) at ../../Source/JavaScriptCore/interpreter/JSStackInlines.h:213 #14 0x00002b83a689bfb4 in JSC::JITCode::execute (this=0x2b83fa88a690, stack=0x889c00, callFrame=0x2b83fa2c3060, globalData=0x87bd60) at ../../Source/JavaScriptCore/jit/JITCode.h:135 #15 0x00002b83a6899771 in JSC::Interpreter::executeCall (this=0x889bf0, callFrame=0x2b83fa74e478, function=0x2b83fa7cddf0, callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/JavaScriptCore/interpreter/Interpreter.cpp:1055 #16 0x00002b83a697db2d in JSC::call (exec=0x2b83fa74e478, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/JavaScriptCore/runtime/CallData.cpp:40 #17 0x00002b83a7648435 in WebCore::JSMainThreadExecState::call (exec=0x2b83fa74e478, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../Source/WebCore/bindings/js/JSMainThreadExecState.h:56 #18 0x00002b83a7677937 in WebCore::JSEventListener::handleEvent (this=0x1a29ca0, scriptExecutionContext=0x1a109b0, event=0x1a2a0b0) at ../../Source/WebCore/bindings/js/JSEventListener.cpp:130 #19 0x00002b83a79b7346 in WebCore::EventTarget::fireEventListeners (this=0x102d9c0, event=0x1a2a0b0, d=0x102dab0, entry=...) at ../../Source/WebCore/dom/EventTarget.cpp:256 #20 0x00002b83a79b6fd1 in WebCore::EventTarget::fireEventListeners (this=0x102d9c0, event=0x1a2a0b0) at ../../Source/WebCore/dom/EventTarget.cpp:203 #21 0x00002b83a7f0339e in WebCore::DOMWindow::dispatchEvent (this=0x102d9c0, prpEvent=..., prpTarget=...) at ../../Source/WebCore/page/DOMWindow.cpp:1708 #22 0x00002b83a7f03124 in WebCore::DOMWindow::dispatchLoadEvent (this=0x102d9c0) at ../../Source/WebCore/page/DOMWindow.cpp:1682 #23 0x00002b83a7925c75 in WebCore::Document::dispatchWindowLoadEvent (this=0x1a10910) at ../../Source/WebCore/dom/Document.cpp:3638 #24 0x00002b83a7921037 in WebCore::Document::implicitClose (this=0x1a10910) at ../../Source/WebCore/dom/Document.cpp:2395 #25 0x00002b83a7e4f5c7 in WebCore::FrameLoader::checkCallImplicitClose (this=0x820480) at ../../Source/WebCore/loader/FrameLoader.cpp:835 #26 0x00002b83a7e4f345 in WebCore::FrameLoader::checkCompleted (this=0x820480) at ../../Source/WebCore/loader/FrameLoader.cpp:778 #27 0x00002b83a7e4f099 in WebCore::FrameLoader::finishedParsing (this=0x820480) at ../../Source/WebCore/loader/FrameLoader.cpp:711 #28 0x00002b83a792884b in WebCore::Document::finishedParsing (this=0x1a10910) at ../../Source/WebCore/dom/Document.cpp:4397 #29 0x00002b83a7c24d87 in WebCore::HTMLConstructionSite::finishedParsing (this=0x1a14540) at ../../Source/WebCore/html/parser/HTMLConstructionSite.cpp:339 #30 0x00002b83a7c5b690 in WebCore::HTMLTreeBuilder::finished (this=0x1a14520) at ../../Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2934 #31 0x00002b83a7c2c164 in WebCore::HTMLDocumentParser::end (this=0x1a130d0) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:641 #32 0x00002b83a7c2c26b in WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd (this=0x1a130d0) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:650 #33 0x00002b83a7c2adeb in WebCore::HTMLDocumentParser::prepareToStopParsing (this=0x1a130d0) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:191 #34 0x00002b83a7c2c2b0 in WebCore::HTMLDocumentParser::attemptToEnd (this=0x1a130d0) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:662 #35 0x00002b83a7c2c369 in WebCore::HTMLDocumentParser::finish (this=0x1a130d0) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:711 #36 0x00002b83a7e47751 in WebCore::DocumentWriter::end (this=0x19fe368) at ../../Source/WebCore/loader/DocumentWriter.cpp:244 #37 0x00002b83a7e364a8 in WebCore::DocumentLoader::finishedLoading (this=0x19fe2c0) at ../../Source/WebCore/loader/DocumentLoader.cpp:295 #38 0x00002b83a7e8ada4 in WebCore::MainResourceLoader::didFinishLoading (this=0x198ce50, finishTime=0) at ../../Source/WebCore/loader/MainResourceLoader.cpp:563 #39 0x00002b83a7e8af9f in WebCore::MainResourceLoader::notifyFinished (this=0x198ce50, resource=0x19fd170) at ../../Source/WebCore/loader/MainResourceLoader.cpp:580 #40 0x00002b83a7e12d14 in WebCore::CachedResource::checkNotify (this=0x19fd170) at ../../Source/WebCore/loader/cache/CachedResource.cpp:378 #41 0x00002b83a7e12d6e in WebCore::CachedResource::data (this=0x19fd170, allDataReceived=true) at ../../Source/WebCore/loader/cache/CachedResource.cpp:387 #42 0x00002b83a7e0f5ea in WebCore::CachedRawResource::data (this=0x19fd170, data=..., allDataReceived=true) at ../../Source/WebCore/loader/cache/CachedRawResource.cpp:72 #43 0x00002b83a7ea296e in WebCore::SubresourceLoader::didFinishLoading (this=0x19febc0, finishTime=0) at ../../Source/WebCore/loader/SubresourceLoader.cpp:278 #44 0x00002b83a7e982bf in WebCore::ResourceLoader::didFinishLoading (this=0x19febc0, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:466 #45 0x00002b83a8895f60 in WebCore::readCallback (asyncResult=0x1371a50, data=0x183e0e0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1359 #46 0x00002b83ac752e5f in async_ready_callback_wrapper () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libgio-2.0.so.0 #47 0x00002b83ac76d7ea in g_simple_async_result_complete () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libgio-2.0.so.0 #48 0x00002b83ac76d9b2 in complete_in_idle_cb_for_thread () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libgio-2.0.so.0 #49 0x00002b83ac933fd1 in g_idle_dispatch () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0 #50 0x00002b83ac931903 in g_main_dispatch () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0 #51 0x00002b83ac9324b3 in g_main_context_dispatch () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0 #52 0x00002b83ac9326a3 in g_main_context_iterate () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0 #53 0x00002b83ac932ad3 in g_main_loop_run () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libglib-2.0.so.0 #54 0x00002b83ab91ce22 in gtk_main () from /home/slave/webkitgtk/gtk-linux-64-debug-wk1/build/WebKitBuild/Dependencies/Root/lib64/libgtk-3.so.0 #55 0x000000000049b889 in runTest (inputLine=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:768 #56 0x000000000049af3f in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:551 #57 0x000000000049e26d in main (argc=2, argv=0x7fff21906868) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1510 ... STDERR: ERROR:../../Tools/DumpRenderTree/gtk/EventSender.cpp:471:const OpaqueJSValue* mouseScrollByCallback(JSContextRef, JSObjectRef, JSObjectRef, size_t, const OpaqueJSValue* const*, const OpaqueJSValue**): code should not be reached
Attachments
Patch (2.98 KB, patch)
2013-07-09 07:10 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anton Obzhirov
Comment 1 2013-07-09 07:10:39 PDT
Created attachment 206318 [details] Patch
WebKit Commit Bot
Comment 2 2013-07-16 06:02:37 PDT
Comment on attachment 206318 [details] Patch Clearing flags on attachment: 206318 Committed r152718: <http://trac.webkit.org/changeset/152718>
WebKit Commit Bot
Comment 3 2013-07-16 06:02:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.