Bug 11021

Summary:

Bring animation back to life

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
resurrects basic animation (animateColor), cleans up animation code	mitz: review+
A basic test case (which seems to fail, probably due to invalidation issues)	none
a more complicated example that does work (strange, eh?)	none

Eric Seidel (no email)

Reported 2006-09-25 05:35:00 PDT

Bring animation back to life SVG animation died a while back. Unfortunately we never noticed. I brought it back to life tonight, by fixing some stupid typos from when I last changed the code, and wiring up an area I had forgotten. I also hosed off some of the Animation code while I was there.

Attachments
resurrects basic animation (animateColor), cleans up animation code (28.71 KB, patch) 2006-09-25 05:38 PDT, Eric Seidel (no email)	mitz: review+	Details Formatted Diff Diff
A basic test case (which seems to fail, probably due to invalidation issues) (219 bytes, image/svg+xml) 2006-09-25 05:45 PDT, Eric Seidel (no email)	no flags	Details
a more complicated example that does work (strange, eh?) (272 bytes, image/svg+xml) 2006-09-25 05:50 PDT, Eric Seidel (no email)	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2006-09-25 05:38:40 PDT

Created attachment 10753 [details] resurrects basic animation (animateColor), cleans up animation code Animation-triggered invalidation seems to be completely busted. Not sure why. At least now the timers are wired up correctly and firing correctly.

Eric Seidel (no email)

Comment 2 2006-09-25 05:45:12 PDT

Created attachment 10754 [details] A basic test case (which seems to fail, probably due to invalidation issues)

Eric Seidel (no email)

Comment 3 2006-09-25 05:50:07 PDT

Created attachment 10755 [details] a more complicated example that does work (strange, eh?)

mitz

Comment 4 2006-09-26 05:03:10 PDT

Comment on attachment 10753 [details] resurrects basic animation (animateColor), cleans up animation code Looks good. Please edit the ChangeLog to point out the significant changes and additions).

mitz

Comment 5 2006-09-26 05:03:54 PDT

Comment on attachment 10753 [details] resurrects basic animation (animateColor), cleans up animation code Forgot to say the magic words. r=me

Eric Seidel (no email)

Comment 6 2006-09-26 05:35:16 PDT

r16572. Thanks again mitz!

Note You need to log in before you can comment on or make changes to this bug.