Summary:  [Qt] Enable MathML  

Product:  WebKit  Reporter:  Allan Sandfeld Jensen <allan.jensen>  
Component:  MathML  Assignee:  Allan Sandfeld Jensen <allan.jensen>  
Status:  RESOLVED INVALID  
Severity:  Normal  CC:  abecsi, andersca, dbarton, fred.wang, hausmann, mrobinson, vestbo, webkit.review.bot  
Priority:  P2  
Version:  528+ (Nightly build)  
Hardware:  Unspecified  
OS:  Unspecified  
Bug Depends on:  110214, 121416  
Bug Blocks:  
Attachments: 

Description
Allan Sandfeld Jensen
20130219 03:55:26 PST
Created attachment 189053 [details]
Patch
Attachment 189053 [details] did not pass stylequeue:
Failed to run "['Tools/Scripts/checkwebkitstyle', 'difffiles', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt/mathml/presentation/attributesexpected.png', u'LayoutTests/platform/qt/mathml/presentation/attributesexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/fencedexpected.png', u'LayoutTests/platform/qt/mathml/presentation/fencedexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/fencedmiexpected.png', u'LayoutTests/platform/qt/mathml/presentation/fencedmiexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/fractionsexpected.png', u'LayoutTests/platform/qt/mathml/presentation/fractionsexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/fractionsverticalalignmentexpected.png', u'LayoutTests/platform/qt/mathml/presentation/fractionsverticalalignmentexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/moexpected.png', u'LayoutTests/platform/qt/mathml/presentation/moexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/mostretchexpected.png', u'LayoutTests/platform/qt/mathml/presentation/mostretchexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/mrootprefwidthexpected.png', u'LayoutTests/platform/qt/mathml/presentation/mrootprefwidthexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/overexpected.png', u'LayoutTests/platform/qt/mathml/presentation/overexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/rootsexpected.png', u'LayoutTests/platform/qt/mathml/presentation/rootsexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/rowalignmentexpected.png', u'LayoutTests/platform/qt/mathml/presentation/rowalignmentexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/rowexpected.png', u'LayoutTests/platform/qt/mathml/presentation/rowexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/styleexpected.png', u'LayoutTests/platform/qt/mathml/presentation/styleexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/subexpected.png', u'LayoutTests/platform/qt/mathml/presentation/subexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/subsupexpected.png', u'LayoutTests/platform/qt/mathml/presentation/subsupexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/supexpected.png', u'LayoutTests/platform/qt/mathml/presentation/supexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/tablesexpected.png', u'LayoutTests/platform/qt/mathml/presentation/tablesexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/tokenElementsexpected.png', u'LayoutTests/platform/qt/mathml/presentation/tokenElementsexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/underexpected.png', u'LayoutTests/platform/qt/mathml/presentation/underexpected.txt', u'LayoutTests/platform/qt/mathml/presentation/underoverexpected.png', u'LayoutTests/platform/qt/mathml/presentation/underoverexpected.txt', u'LayoutTests/platform/qt/mathml/xHeightexpected.png', u'LayoutTests/platform/qt/mathml/xHeightexpected.txt', u'Tools/ChangeLog', u'Tools/qmake/mkspecs/features/features.pri']" exit_code: 1
LayoutTests/platform/qt/mathml/presentation/tablesexpected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enableautoprops = yes"). Have to set the svn:mimetype in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mimetype=image/png"). [image/png] [5]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against checkwebkitstyle.
Committed r143319: <http://trac.webkit.org/changeset/143319> Reopened since this is blocked by bug 110214 The architecture concerns of Chromium developers should be fixed after bug 121416. The pixel tests have now all been converted or disabled, so we don't need to add QTspecific references. It seems that qmake/mkspecs/features/features.pri has been removed after bug 122227. Actually, is the QT port still supported / has bots? The patch didn't have other changes, so what does it remain to do to enable MathML on QT? More generally, it seems that Source/autotools/SetupWebKitFeatures.m4 has MathML disabled by default. What is the status of MathML in release builds and could that be reconsidered after bug 121416? Is it only enabled in Safari? The Qt port no longer exists now, so we can close this one. 