[Qt] Enable MathML

• Component: MathML
• Status: RESOLVED INVALID

[Allan Sandfeld Jensen]

MathML works now when enabled in the Qt, so we should enable it. 

The MathML baselines needs to be generated.

[Allan Sandfeld Jensen]

Created attachment 189053 [details]
Patch

[WebKit Review Bot]

Attachment 189053 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt/mathml/presentation/attributes-expected.png', u'LayoutTests/platform/qt/mathml/presentation/attributes-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/fenced-expected.png', u'LayoutTests/platform/qt/mathml/presentation/fenced-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/fenced-mi-expected.png', u'LayoutTests/platform/qt/mathml/presentation/fenced-mi-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/fractions-expected.png', u'LayoutTests/platform/qt/mathml/presentation/fractions-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png', u'LayoutTests/platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/mo-expected.png', u'LayoutTests/platform/qt/mathml/presentation/mo-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/mo-stretch-expected.png', u'LayoutTests/platform/qt/mathml/presentation/mo-stretch-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/mroot-pref-width-expected.png', u'LayoutTests/platform/qt/mathml/presentation/mroot-pref-width-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/over-expected.png', u'LayoutTests/platform/qt/mathml/presentation/over-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/roots-expected.png', u'LayoutTests/platform/qt/mathml/presentation/roots-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/row-alignment-expected.png', u'LayoutTests/platform/qt/mathml/presentation/row-alignment-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/row-expected.png', u'LayoutTests/platform/qt/mathml/presentation/row-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/style-expected.png', u'LayoutTests/platform/qt/mathml/presentation/style-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/sub-expected.png', u'LayoutTests/platform/qt/mathml/presentation/sub-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/subsup-expected.png', u'LayoutTests/platform/qt/mathml/presentation/subsup-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/sup-expected.png', u'LayoutTests/platform/qt/mathml/presentation/sup-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/tables-expected.png', u'LayoutTests/platform/qt/mathml/presentation/tables-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/tokenElements-expected.png', u'LayoutTests/platform/qt/mathml/presentation/tokenElements-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/under-expected.png', u'LayoutTests/platform/qt/mathml/presentation/under-expected.txt', u'LayoutTests/platform/qt/mathml/presentation/underover-expected.png', u'LayoutTests/platform/qt/mathml/presentation/underover-expected.txt', u'LayoutTests/platform/qt/mathml/xHeight-expected.png', u'LayoutTests/platform/qt/mathml/xHeight-expected.txt', u'Tools/ChangeLog', u'Tools/qmake/mkspecs/features/features.pri']" exit_code: 1
LayoutTests/platform/qt/mathml/presentation/tables-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Allan Sandfeld Jensen]

Committed r143319: <http://trac.webkit.org/changeset/143319>

[WebKit Review Bot]

Re-opened since this is blocked by bug 110214

[Frédéric Wang (:fredw)]

The architecture concerns of Chromium developers should be fixed after bug 121416.

The pixel tests have now all been converted or disabled, so we don't need to add QT-specific references.

It seems that qmake/mkspecs/features/features.pri has been removed after bug 122227. Actually, is the QT port still supported / has bots?

The patch didn't have other changes, so what does it remain to do to enable MathML on QT?

More generally, it seems that Source/autotools/SetupWebKitFeatures.m4 has MathML disabled by default. What is the status of MathML in release builds and could that be reconsidered after bug 121416? Is it only enabled in Safari?

[Martin Robinson]

The Qt port no longer exists now, so we can close this one.