Bug 110177

Summary: [JS Binding] ScriptObject default constructor should initialize the Script State to 0
Product: WebKit Reporter: Vivek Galatage <vivekg>
Component: WebCore JavaScriptAssignee: Vivek Galatage <vivekg>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, msaboff, oliver, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Vivek Galatage
Reported 2013-02-18 22:25:54 PST
ScriptObject default constructor should initialize the Script State to 0. V8 binding has already done the initialization( http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/ScriptObject.h#L47 ). Adding it for JS binding. Patch follows.
Attachments
Patch (1.45 KB, patch)
2013-02-18 22:28 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2013-02-18 22:28:45 PST
Created attachment 188989 [details] Patch
Geoffrey Garen
Comment 2 2013-02-18 23:01:59 PST
Is there a regression test for this?
Vivek Galatage
Comment 3 2013-02-18 23:16:55 PST
(In reply to comment #2) > Is there a regression test for this? Unfortunately I couldn't find any regression test handy for this at the moment. I am trying to create empty InjectedScript in a case when the JavaScript is disabled across the browser. During this, I found that the ScriptState is not initialized to 0.
Vivek Galatage
Comment 4 2013-02-21 11:08:31 PST
@Geoffrey I am not sure how to write a test case for this error scenario as I am finding it as a non-trivial case. Do you have any suggestion about writing the test scenario for it? Thank you.
Geoffrey Garen
Comment 5 2013-02-21 11:09:30 PST
Comment on attachment 188989 [details] Patch OK. r=me
Vivek Galatage
Comment 6 2013-02-21 11:11:32 PST
Comment on attachment 188989 [details] Patch Thank you!
WebKit Review Bot
Comment 7 2013-02-21 11:22:07 PST
Comment on attachment 188989 [details] Patch Clearing flags on attachment: 188989 Committed r143631: <http://trac.webkit.org/changeset/143631>
WebKit Review Bot
Comment 8 2013-02-21 11:22:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.