Bug 110173

Summary:	[Mac] Intermittent crash on media/video-controls-captions-trackmenu.html
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	andersca, dino, jer.noble
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	122021
Bug Blocks:

Ryosuke Niwa

Reported 2013-02-18 19:49:04 PST

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=media%2Fvideo-controls-captions-trackmenu.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000101f4df8d WebCore::HTMLMediaElement::captionPreferencesChanged() + 13 (HTMLMediaElement.cpp:4449) 1 com.apple.WebCore 0x00000001027a2c48 WebCore::CaptionUserPreferences::captionPreferencesChanged() + 88 (CaptionUserPreferences.cpp:62) 2 com.apple.WebCore 0x0000000101f4bde3 WebCore::HTMLMediaElement::toggleTrackAtIndex(int, bool) + 163 (HTMLMediaElement.cpp:3126) 3 com.apple.WebCore 0x0000000102412786 WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler(WebCore::Event*) + 182 (MediaControlElements.cpp:765) 4 com.apple.WebCore 0x0000000101e180fd WebCore::EventDispatcher::dispatchEventPostProcess(WTF::PassRefPtr<WebCore::Event>, void*) + 365 (PassRefPtr.h:77) 5 com.apple.WebCore 0x0000000101e17e8f WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 1119 (PassRefPtr.h:68) 6 com.apple.WebCore 0x000000010243fb15 WebCore::MouseEventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const + 277 (PassRefPtr.h:68) 7 com.apple.WebCore 0x0000000101e16f00 WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr<WebCore::EventDispatchMediator>) + 160 (EventDispatcher.cpp:55) 8 com.apple.WebCore 0x0000000102454485 WebCore::Node::dispatchMouseEvent(WebCore::PlatformMouseEvent const&, WTF::AtomicString const&, int, WebCore::Node*) + 133 (Node.cpp:2378) 9 com.apple.WebCore 0x0000000101e1e5ae WebCore::EventHandler::dispatchMouseEvent(WTF::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool) + 110 (EventHandler.cpp:2235) 10 com.apple.WebCore 0x0000000101e20112 WebCore::EventHandler::handleMouseReleaseEvent(WebCore::PlatformMouseEvent const&) + 1330 (EventHandler.cpp:1848) 11 com.apple.WebCore 0x0000000101e2604e WebCore::EventHandler::mouseUp(NSEvent*) + 190 (EventHandlerMac.mm:516) 12 com.apple.WebKit 0x0000000101847dff -[WebHTMLView mouseUp:] + 223 (WebHTMLView.mm:3762) 13 DumpRenderTree 0x00000001010ed52b -[EventSendingController mouseUp:withModifiers:] + 664 (EventSendingController.mm:426) 14 com.apple.CoreFoundation 0x00007fff8ee6563c __invoking___ + 140 15 com.apple.CoreFoundation 0x00007fff8ee654d7 -[NSInvocation invoke] + 263 16 DumpRenderTree 0x00000001010edf24 +[EventSendingController replaySavedEvents] + 159 (EventSendingController.mm:574) 17 DumpRenderTree 0x00000001010ed37c -[EventSendingController mouseUp:withModifiers:] + 233 (EventSendingController.mm:402) 18 com.apple.CoreFoundation 0x00007fff8ee6563c __invoking___ + 140 19 com.apple.CoreFoundation 0x00007fff8ee654d7 -[NSInvocation invoke] + 263 20 com.apple.WebCore 0x0000000102464082 JSC::Bindings::ObjcInstance::invokeObjcMethod(JSC::ExecState*, JSC::Bindings::ObjcMethod*) + 1042 (objc_instance.mm:323) 21 com.apple.WebCore 0x0000000102463bcd JSC::Bindings::ObjcInstance::invokeMethod(JSC::ExecState*, JSC::RuntimeMethod*) + 93 (objc_instance.mm:232) 22 com.apple.WebCore 0x0000000102649700 JSC::callRuntimeMethod(JSC::ExecState*) + 240 (runtime_method.cpp:115) 23 com.apple.JavaScriptCore 0x00000001013efe0e JSC::LLInt::setUpCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*) + 254 (LLIntSlowPaths.cpp:1364) 24 com.apple.JavaScriptCore 0x00000001013f44ed llint_op_call + 169 25 com.apple.JavaScriptCore 0x000000010131b7c3 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 611 (JSCJSValueInlines.h:363) 26 com.apple.JavaScriptCore 0x00000001012240b5 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 69 (CallData.cpp:40) 27 com.apple.WebCore 0x00000001020c2fde WebCore::JSMainThreadExecState::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 190 (JSMainThreadExecState.h:56) 28 com.apple.WebCore 0x000000010264ce61 WebCore::ScheduledAction::executeFunctionInContext(JSC::JSGlobalObject*, JSC::JSValue, WebCore::ScriptExecutionContext*) + 529 (ScheduledAction.cpp:112) 29 com.apple.WebCore 0x000000010264cacc WebCore::ScheduledAction::execute(WebCore::Document*) + 156 (ScheduledAction.cpp:134) 30 com.apple.WebCore 0x0000000101dc9bf4 WebCore::DOMTimer::fired() + 388 (InspectorInstrumentation.h:289) 31 com.apple.WebCore 0x000000010282410f WebCore::ThreadTimers::sharedTimerFiredInternal() + 175 (ThreadTimers.cpp:132) 32 com.apple.WebCore 0x00000001026b0e73 WebCore::timerFired(__CFRunLoopTimer*, void*) + 51 (SharedTimerMac.mm:167) 33 com.apple.CoreFoundation 0x00007fff8ee2eda4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 34 com.apple.CoreFoundation 0x00007fff8ee2e8bd __CFRunLoopDoTimer + 557 35 com.apple.CoreFoundation 0x00007fff8ee14099 __CFRunLoopRun + 1513 36 com.apple.CoreFoundation 0x00007fff8ee136b2 CFRunLoopRunSpecific + 290 37 com.apple.Foundation 0x00007fff83de789e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 268 38 DumpRenderTree 0x00000001010e7d7c runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 1639 (DumpRenderTree.mm:1375) 39 DumpRenderTree 0x00000001010e7510 dumpRenderTree(int, char const**) + 1727 (DumpRenderTree.mm:832) 40 DumpRenderTree 0x00000001010e80e5 main + 86 (DumpRenderTree.mm:925) 41 libdyld.dylib 0x00007fff858ea7e1 start + 1

Attachments
Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2013-02-18 23:43:11 PST

Added a failing test expectation in http://trac.webkit.org/changeset/143291.

Alexey Proskuryakov

Comment 2 2013-09-27 14:10:48 PDT

This code was all rewritten, and the test now just fails. That's tracked as bug 122021, so closing this bug as obsolete. Removed old Pass/Crash entry from ChangeLog in r156572, as it was confusing the parser, making it ignore the new Skip one.

Note You need to log in before you can comment on or make changes to this bug.