Bug 110167

Summary: Clean up the boolean argument to visibleContentRect
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dglazkov, eric, gyuyoung.kim, mifenton, ojan.autocc, philn, rakuco, rwlbuis, sam, simon.fraser, thakis, tonikitoo, webkit.review.bot, xan.lopez, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110189    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
We'll get there eventually none

Description Simon Fraser (smfr) 2013-02-18 16:54:07 PST 
Clean up the boolean argument to visibleContentRect
Comment 1 Simon Fraser (smfr) 2013-02-18 16:58:35 PST 
Created attachment 188963 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-18 17:14:49 PST 
Comment on attachment 188963 [details]
Patch

Attachment 188963 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16626287
Comment 3 WebKit Review Bot 2013-02-18 17:15:26 PST 
Comment on attachment 188963 [details]
Patch

Attachment 188963 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16625291
Comment 4 EFL EWS Bot 2013-02-18 17:23:17 PST 
Comment on attachment 188963 [details]
Patch

Attachment 188963 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16627236
Comment 5 Simon Fraser (smfr) 2013-02-18 17:31:12 PST 
Created attachment 188968 [details]
Patch
Comment 6 EFL EWS Bot 2013-02-18 17:47:27 PST 
Comment on attachment 188968 [details]
Patch

Attachment 188968 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16615436
Comment 7 WebKit Review Bot 2013-02-18 17:47:37 PST 
Comment on attachment 188968 [details]
Patch

Attachment 188968 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16608579
Comment 8 WebKit Review Bot 2013-02-18 17:48:37 PST 
Comment on attachment 188968 [details]
Patch

Attachment 188968 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16617383
Comment 9 Simon Fraser (smfr) 2013-02-18 17:57:55 PST 
Created attachment 188970 [details]
Patch
Comment 10 WebKit Review Bot 2013-02-18 18:17:23 PST 
Comment on attachment 188970 [details]
Patch

Attachment 188970 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16627248
Comment 11 WebKit Review Bot 2013-02-18 18:27:32 PST 
Comment on attachment 188970 [details]
Patch

Attachment 188970 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16617399
Comment 12 Simon Fraser (smfr) 2013-02-18 19:27:31 PST 
Created attachment 188975 [details]
Patch
Comment 13 WebKit Review Bot 2013-02-18 19:45:29 PST 
Comment on attachment 188975 [details]
Patch

Attachment 188975 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16610555
Comment 14 WebKit Review Bot 2013-02-18 19:51:50 PST 
Comment on attachment 188975 [details]
Patch

Attachment 188975 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16612488
Comment 15 Simon Fraser (smfr) 2013-02-18 20:28:53 PST 
Created attachment 188977 [details]
We'll get there eventually
Comment 16 WebKit Review Bot 2013-02-18 22:37:10 PST 
Comment on attachment 188977 [details]
We'll get there eventually

Clearing flags on attachment: 188977

Committed r143295: <http://trac.webkit.org/changeset/143295>
Comment 17 WebKit Review Bot 2013-02-18 22:37:16 PST 
All reviewed patches have been landed.  Closing bug.