Bug 110167

Summary: Clean up the boolean argument to visibleContentRect
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dglazkov, eric, gyuyoung.kim, mifenton, ojan.autocc, philn, rakuco, rwlbuis, sam, simon.fraser, thakis, tonikitoo, webkit.review.bot, xan.lopez, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110189    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
We'll get there eventually none

Simon Fraser (smfr)
Reported 2013-02-18 16:54:07 PST
Clean up the boolean argument to visibleContentRect
Attachments
Patch (31.44 KB, patch)
2013-02-18 16:58 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (34.47 KB, patch)
2013-02-18 17:31 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (35.22 KB, patch)
2013-02-18 17:57 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (35.22 KB, patch)
2013-02-18 19:27 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
We'll get there eventually (35.24 KB, patch)
2013-02-18 20:28 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-02-18 16:58:35 PST
Created attachment 188963 [details] Patch
WebKit Review Bot
Comment 2 2013-02-18 17:14:49 PST
Comment on attachment 188963 [details] Patch Attachment 188963 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16626287
WebKit Review Bot
Comment 3 2013-02-18 17:15:26 PST
Comment on attachment 188963 [details] Patch Attachment 188963 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16625291
EFL EWS Bot
Comment 4 2013-02-18 17:23:17 PST
Comment on attachment 188963 [details] Patch Attachment 188963 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16627236
Simon Fraser (smfr)
Comment 5 2013-02-18 17:31:12 PST
Created attachment 188968 [details] Patch
EFL EWS Bot
Comment 6 2013-02-18 17:47:27 PST
Comment on attachment 188968 [details] Patch Attachment 188968 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16615436
WebKit Review Bot
Comment 7 2013-02-18 17:47:37 PST
Comment on attachment 188968 [details] Patch Attachment 188968 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16608579
WebKit Review Bot
Comment 8 2013-02-18 17:48:37 PST
Comment on attachment 188968 [details] Patch Attachment 188968 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16617383
Simon Fraser (smfr)
Comment 9 2013-02-18 17:57:55 PST
Created attachment 188970 [details] Patch
WebKit Review Bot
Comment 10 2013-02-18 18:17:23 PST
Comment on attachment 188970 [details] Patch Attachment 188970 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16627248
WebKit Review Bot
Comment 11 2013-02-18 18:27:32 PST
Comment on attachment 188970 [details] Patch Attachment 188970 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16617399
Simon Fraser (smfr)
Comment 12 2013-02-18 19:27:31 PST
Created attachment 188975 [details] Patch
WebKit Review Bot
Comment 13 2013-02-18 19:45:29 PST
Comment on attachment 188975 [details] Patch Attachment 188975 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16610555
WebKit Review Bot
Comment 14 2013-02-18 19:51:50 PST
Comment on attachment 188975 [details] Patch Attachment 188975 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16612488
Simon Fraser (smfr)
Comment 15 2013-02-18 20:28:53 PST
Created attachment 188977 [details] We'll get there eventually
WebKit Review Bot
Comment 16 2013-02-18 22:37:10 PST
Comment on attachment 188977 [details] We'll get there eventually Clearing flags on attachment: 188977 Committed r143295: <http://trac.webkit.org/changeset/143295>
WebKit Review Bot
Comment 17 2013-02-18 22:37:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.