Bug 110163

Summary: Add StorageManager member functions for keeping track of session storage namespaces
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Severity: Normal CC: cdumez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 110212    
Bug Blocks:    
Description Flags
Patch kling: review+

Description Anders Carlsson 2013-02-18 15:53:55 PST
Add StorageManager member functions for keeping track of session storage namespaces
Comment 1 Anders Carlsson 2013-02-18 15:55:10 PST
Created attachment 188957 [details]
Comment 2 Anders Carlsson 2013-02-18 16:05:54 PST
Committed r143273: <http://trac.webkit.org/changeset/143273>
Comment 3 Chris Dumez 2013-02-19 05:32:59 PST
Comment on attachment 188957 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=188957&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:56
> +    m_queue->dispatch(bind(&StorageManager::destroySessionStorageNamespace, this, storageNamespaceID));

Shouldn't this be destroySessionStorageNamespaceInternal?

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:61
> +    m_queue->dispatch(bind(&StorageManager::cloneSessionStorageNamespace, this, storageNamespaceID, newStorageNamespaceID));

Shouldn't this be cloneSessionStorageNamespaceInternal?
Comment 4 Chris Dumez 2013-02-19 05:44:04 PST
I uploaded a patch at Bug 110212 to address this issue as it seems to cause a lot of tests to time out on our bots. StorageManager::cloneSessionStorageNamespace() is called when a new window is opened (for example in Web Inspector tests) and StorageManager::cloneSessionStorageNamespace() just keeps calling itself.