Bug 110139 – [WK2][Efl][CMake] Add support for ENABLE_NETWORK_PROCESS to the build system

• Component: WebKit2
• Status: RESOLVED FIXED

[Balazs Kelemen]

Add the files, an executable target, and an option to the CMake build system (disabled by default).

[Balazs Kelemen]

Created attachment 188915 [details]
Patch

[Laszlo Gombos]

New feature flags for CMake based ports are also usually added to Source/cmake/WebKitFeatures.cmake - this seems to be missing, otherwise it looks good to me.

This should probably only land after the files built are landed in the tree.

[EFL EWS Bot]

Comment on attachment 188915 [details]
Patch

Attachment 188915 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16614308

[Gyuyoung Kim]

Comment on attachment 188915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188915&action=review

Other things looks fine as well.

> Source/WebKit2/CMakeLists.txt:390
> +    UIProcess/soup/WebContextSoup.cpp

To avoid build break, do you need to land this file together ?

> Source/WebKit2/unix/NetworkMainUnix.cpp:26
> +#include "config.h"

AFAIK, WebKit prefers to add a new line below config.h

[Balazs Kelemen]

(In reply to comment #4)
> (From update of attachment 188915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188915&action=review
> 
> Other things looks fine as well.
> 
> > Source/WebKit2/CMakeLists.txt:390
> > +    UIProcess/soup/WebContextSoup.cpp
> 
> To avoid build break, do you need to land this file together ?

I forgot to set the blocking meta bug. If we land the patches that blocks 108832 in the order they are enumerated there, the build will be fine with -DENABLE_NETWORK_PROCESS, although it won't be turned on by default so it should not matter. Particularly this file is added in bug 110115.

> 
> > Source/WebKit2/unix/NetworkMainUnix.cpp:26
> > +#include "config.h"
> 
> AFAIK, WebKit prefers to add a new line below config.h

Ok. I will to fix this and incorporate the comment from Laszlo and reupload.

[Balazs Kelemen]

Created attachment 189069 [details]
Patch

[EFL EWS Bot]

Comment on attachment 189069 [details]
Patch

Attachment 189069 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16621708

[Gyuyoung Kim]

Comment on attachment 189069 [details]
Patch

Set r- because of failing on efl ews.

[Csaba Osztrogonác]

Comment on attachment 189069 [details]
Patch

It is obsolete, I'll submit the updated patch soon.

[Csaba Osztrogonác]

Created attachment 213003 [details]
patch

updated to ToT - r156645.

[Csaba Osztrogonác]

(In reply to comment #10)
> Created an attachment (id=213003) [details]
> patch
> 
> updated to ToT - r156645.

Of course, it doesn't apply now, because it depends on other patches.

[Csaba Osztrogonác]

Created attachment 214250 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #12)
> Created an attachment (id=214250) [details]
> Patch

The build works fine with !ENABLE(NETWORK_PROCESS), so it's safe to land it now.
Is there any cmake reviewer near here for an easy r+ ? :)

[Laszlo Gombos]

Comment on attachment 214250 [details]
Patch

r=me.

[Csaba Osztrogonác]

Landed in http://trac.webkit.org/changeset/157504