Bug 110139

Summary: [WK2][Efl][CMake] Add support for ENABLE_NETWORK_PROCESS to the build system
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, kenneth, laszlo.gombos, ossy, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108832    
Attachments:
Description Flags
Patch
none
Patch
none
patch
none
Patch none

Description Balazs Kelemen 2013-02-18 09:58:50 PST
Add the files, an executable target, and an option to the CMake build system (disabled by default).
Comment 1 Balazs Kelemen 2013-02-18 10:21:21 PST
Created attachment 188915 [details]
Patch
Comment 2 Laszlo Gombos 2013-02-18 10:47:37 PST
New feature flags for CMake based ports are also usually added to Source/cmake/WebKitFeatures.cmake - this seems to be missing, otherwise it looks good to me.

This should probably only land after the files built are landed in the tree.
Comment 3 EFL EWS Bot 2013-02-18 11:15:07 PST
Comment on attachment 188915 [details]
Patch

Attachment 188915 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16614308
Comment 4 Gyuyoung Kim 2013-02-18 17:09:20 PST
Comment on attachment 188915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188915&action=review

Other things looks fine as well.

> Source/WebKit2/CMakeLists.txt:390
> +    UIProcess/soup/WebContextSoup.cpp

To avoid build break, do you need to land this file together ?

> Source/WebKit2/unix/NetworkMainUnix.cpp:26
> +#include "config.h"

AFAIK, WebKit prefers to add a new line below config.h
Comment 5 Balazs Kelemen 2013-02-19 04:52:54 PST
(In reply to comment #4)
> (From update of attachment 188915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188915&action=review
> 
> Other things looks fine as well.
> 
> > Source/WebKit2/CMakeLists.txt:390
> > +    UIProcess/soup/WebContextSoup.cpp
> 
> To avoid build break, do you need to land this file together ?

I forgot to set the blocking meta bug. If we land the patches that blocks 108832 in the order they are enumerated there, the build will be fine with -DENABLE_NETWORK_PROCESS, although it won't be turned on by default so it should not matter. Particularly this file is added in bug 110115.

> 
> > Source/WebKit2/unix/NetworkMainUnix.cpp:26
> > +#include "config.h"
> 
> AFAIK, WebKit prefers to add a new line below config.h

Ok. I will to fix this and incorporate the comment from Laszlo and reupload.
Comment 6 Balazs Kelemen 2013-02-19 06:01:19 PST
Created attachment 189069 [details]
Patch
Comment 7 EFL EWS Bot 2013-02-19 06:29:15 PST
Comment on attachment 189069 [details]
Patch

Attachment 189069 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16621708
Comment 8 Gyuyoung Kim 2013-06-12 18:35:06 PDT
Comment on attachment 189069 [details]
Patch

Set r- because of failing on efl ews.
Comment 9 Csaba Osztrogonác 2013-08-26 08:20:34 PDT
Comment on attachment 189069 [details]
Patch

It is obsolete, I'll submit the updated patch soon.
Comment 10 Csaba Osztrogonác 2013-09-30 08:58:33 PDT
Created attachment 213003 [details]
patch

updated to ToT - r156645.
Comment 11 Csaba Osztrogonác 2013-09-30 09:00:16 PDT
(In reply to comment #10)
> Created an attachment (id=213003) [details]
> patch
> 
> updated to ToT - r156645.

Of course, it doesn't apply now, because it depends on other patches.
Comment 12 Csaba Osztrogonác 2013-10-15 05:27:30 PDT
Created attachment 214250 [details]
Patch
Comment 13 Csaba Osztrogonác 2013-10-15 06:01:33 PDT
(In reply to comment #12)
> Created an attachment (id=214250) [details]
> Patch

The build works fine with !ENABLE(NETWORK_PROCESS), so it's safe to land it now.
Is there any cmake reviewer near here for an easy r+ ? :)
Comment 14 Laszlo Gombos 2013-10-15 17:04:42 PDT
Comment on attachment 214250 [details]
Patch

r=me.
Comment 15 Csaba Osztrogonác 2013-10-16 02:08:25 PDT
Landed in http://trac.webkit.org/changeset/157504