Bug 110134

Summary:

[Chromium] Do not remove spelling markers when moving cursor on misspelled word

Product:

WebKit

Reporter:

Rouslan Solomakhin <rouslan+webkit>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

dglazkov, groby, rniwa, rouslan+webkit, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Rouslan Solomakhin

Reported 2013-02-18 09:32:59 PST

[Chromium] Do not remove spelling markers when moving cursor on misspelled word on Mac

Attachments
Patch (6.42 KB, patch) 2013-02-18 09:44 PST, Rouslan Solomakhin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Rouslan Solomakhin

Comment 1 2013-02-18 09:44:57 PST

Created attachment 188911 [details] Patch

WebKit Review Bot

Comment 2 2013-02-18 12:40:06 PST

Comment on attachment 188911 [details] Patch Attachment 188911 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16626171 New failing tests: editing/execCommand/4924441.html editing/style/create-block-for-style-013.html editing/style/create-block-for-style-011.html editing/style/create-block-for-style-010.html editing/style/create-block-for-style-012.html editing/execCommand/insert-list-and-stitch.html editing/selection/move-by-character-6.html editing/execCommand/5080333-1.html editing/style/create-block-for-style-007.html editing/execCommand/remove-list-item-1.html editing/style/create-block-for-style-004.html fast/loader/text-document-wrapping.html editing/selection/unrendered-005.html editing/selection/move-by-character-001.html editing/style/create-block-for-style-009.html editing/execCommand/5080333-2.html editing/pasteboard/subframe-dragndrop-1.html editing/deleting/delete-3800834-fix.html editing/style/create-block-for-style-003.html editing/selection/4983858.html editing/style/create-block-for-style-001.html editing/inserting/return-key-with-selection-002.html editing/deleting/delete-to-select-table.html editing/style/5046875-1.html editing/pasteboard/smart-paste-008.html editing/inserting/insert-paragraph-04.html editing/deleting/smart-delete-002.html editing/inserting/return-key-with-selection-001.html editing/selection/5057506-2.html fast/loader/javascript-url-in-object.html

Rouslan Solomakhin

Comment 3 2013-02-19 09:29:52 PST

The cr-linux-debug bot succeeded, but cr-linux bot failed. Are there more differences between them than release/debug mode?

Tony Chang

Comment 4 2013-02-19 11:51:59 PST

(In reply to comment #3) > The cr-linux-debug bot succeeded, but cr-linux bot failed. Are there more differences between them than release/debug mode? The debug bot doesn't run tests. It only verifies that things compile.

Rouslan Solomakhin

Comment 5 2013-02-19 18:22:43 PST

Groby: Since you're planning on implementing async spell checking and unified text checking on Mac, let's not land this patch. It will become irrelevant once your change lands.

Eric Seidel (no email)

Comment 6 2013-03-01 02:54:24 PST

Comment on attachment 188911 [details] Patch Cleared review? from attachment 188911 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Rouslan Solomakhin

Comment 7 2013-03-01 09:46:19 PST

Thank you, Eric.

Note You need to log in before you can comment on or make changes to this bug.