Bug 110121

Summary: Remove unnecessary (and problematic) copy-constructor from LayoutUnit
Product: WebKit Reporter: Morten Stenshorne <mstensho>
Component: Layout and RenderingAssignee: Morten Stenshorne <mstensho>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Morten Stenshorne 2013-02-18 07:56:56 PST 
This copy constructor does what a default copy constructor would do, so it's not necessary. Furthermore, this copy constructor is the only reason why LayoutUnit becomes non-POD, and that triggers a gdb bug, making it impossible to do things like "print location()" when inside some RenderBlock, for instance. Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported on that.
Comment 1 Morten Stenshorne 2013-02-18 08:04:06 PST 
Created attachment 188890 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-19 11:12:30 PST 
Comment on attachment 188890 [details]
Patch

Clearing flags on attachment: 188890

Committed r143361: <http://trac.webkit.org/changeset/143361>
Comment 3 WebKit Review Bot 2013-02-19 11:12:33 PST 
All reviewed patches have been landed.  Closing bug.