Bug 110120 – Web Inspector: Text editor exception

• Component: Web Inspector (Deprecated)
• Status: RESOLVED INVALID

[Vsevolod Vlasov]

Uncaught TypeError: Cannot call method 'substring' of undefined TextEditorModel.js:485
WebInspector.TextEditorModel.copyRange TextEditorModel.js:485
WebInspector.TextEditorMainPanel.TokenHighlighter.handleSelectionChange DefaultTextEditor.js:3237
WebInspector.TextEditorMainPanel._handleSelectionChange DefaultTextEditor.js:2750

This happens when UISourceCode content is set to single line text externally.
At this point cursor is shown in the very beginning of the file and window.getSelection returns the following selection:

Selection {type: "Caret", extentOffset: 0, extentNode: div.inner-container text-editor-editable, baseOffset: 0, baseNode: div.inner-container text-editor-editable…}
anchorNode: div.inner-container text-editor-editable
anchorOffset: 0
baseNode: div.inner-container text-editor-editable
baseOffset: 0
extentNode: div.inner-container text-editor-editable
extentOffset: 0
focusNode: div.inner-container text-editor-editable
focusOffset: 0
isCollapsed: true
rangeCount: 1
type: "Caret"
__proto__: Selection

This differs from what window.getSelection() returns when cursor is set to the beginning of the file manually:

Selection {type: "Caret", extentOffset: 0, extentNode: text, baseOffset: 0, baseNode: text…}
anchorNode: text
anchorOffset: 0
baseNode: text
baseOffset: 0
extentNode: text
extentOffset: 0
focusNode: text
focusOffset: 0
isCollapsed: true
rangeCount: 1
type: "Caret"
__proto__: Selection

This is probably the reason of the exception (I saw that the range received in the selectionToPosition method had undefined as start/endLine)

[Andrey Lushnikov]

Created attachment 189036 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 189036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189036&action=review

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:1399
> +        this._restoreSelection(WebInspector.TextRange.createFromLocation(0, 0));

This is going to regress keeping track of selection in delegate.

[Brian Burg]

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.