Bug 110097 – [WK2] Port RemoteNetworkingContext for Soup

• Component: WebKit2
• Status: RESOLVED FIXED

[Balazs Kelemen]

Make this interface portable and add an implementation for the Soup network backend which is used by several ports.

[Sergio Villar Senin]

Being one of the active maintainers of the WK soup backend I'm interested in helping with this effort.

[Balazs Kelemen]

(In reply to comment #1)
> Being one of the active maintainers of the WK soup backend I'm interested in helping with this effort.

Thanks. For now it will mostly be stubs and a bit of refactoring. Later we can implement private browsing sessions which probably requires more soup knowledge.

[Balazs Kelemen]

Created attachment 188871 [details]
Patch

[Kwang Yul Seo]

Created attachment 205782 [details]
Patch

[Kwang Yul Seo]

(In reply to comment #4)
Build fix as RemoteNetworkingContext::privateBrowsingSession is changed to return a pointer in r150537.

[Build Bot]

Comment on attachment 205782 [details]
Patch

Attachment 205782 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1001366

[Build Bot]

Comment on attachment 205782 [details]
Patch

Attachment 205782 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/943930

[Kwang Yul Seo]

Created attachment 205795 [details]
Patch

[Kwang Yul Seo]

(In reply to comment #8)
> Created an attachment (id=205795) [details]
> Patch

Mac build fix. RemoteNetworkingContext::storageSession() was mistakenly declared twice.

[Brady Eidson]

Comment on attachment 205795 [details]
Patch

Seems fine.  I'll let a Soup guy review, then will sign off.

[Sergio Villar Senin]

(In reply to comment #10)
> (From update of attachment 205795 [details])
> Seems fine.  I'll let a Soup guy review, then will sign off.

As this is mostly a refactoring and knowing that there is actually no specific soup code yet, I think you can safely sign off.

[Kwang Yul Seo]

CC'ing Gustavo Noronha Silva

[Kwang Yul Seo]

gns, would you review the patch please?

[Csaba Osztrogonác]

Created attachment 209650 [details]
Patch

Updated to ToT: solved conflicts in project.pbxproj, removed the change in the non-existent SyncNetworkResourceLoader.cpp

[Csaba Osztrogonác]

Comment on attachment 209650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209650&action=review

> Source/WebKit2/ChangeLog:23
> +        * NetworkProcess/SyncNetworkResourceLoader.cpp:
> +        (WebKit::SyncNetworkResourceLoader::start):

It should be removed.

[Csaba Osztrogonác]

Created attachment 212710 [details]
Patch

[Csaba Osztrogonác]

Could you review this patch please?

[Darin Adler]

Comment on attachment 212710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212710&action=review

> Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:34
> +class RemoteNetworkingContext : public WebCore::NetworkingContext {

As long as you are touching this, should mark this class FINAL.

> Source/WebKit2/NetworkProcess/RemoteNetworkingContext.h:54
> +    RemoteNetworkingContext(bool privateBrowsingEnabled, bool shouldClearReferrerOnHTTPSToHTTPRedirect)
> +        : m_privateBrowsingEnabled(privateBrowsingEnabled)
> +        , m_shouldClearReferrerOnHTTPSToHTTPRedirect(shouldClearReferrerOnHTTPSToHTTPRedirect)
> +    { }

This will leave m_needsSiteSpecificQuirks and m_localFileContentSniffingEnabled uninitialized on PLATFORM(MAC), which is not what we want.

[Csaba Osztrogonác]

Created attachment 212794 [details]
Patch

Thanks for the review, I added the FINAL and fixed the initialization.

[Build Bot]

Comment on attachment 212794 [details]
Patch

Attachment 212794 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2659113

[Csaba Osztrogonác]

Created attachment 212796 [details]
Patch

typo fixed

[Csaba Osztrogonác]

(In reply to comment #19)
> Created an attachment (id=212794) [details]
> Patch
> 
> Thanks for the review, I added the FINAL and fixed the initialization.

Darin, could you review the updated patch please?

[Csaba Osztrogonác]

Could you review the fixed patch, please?

[WebKit Commit Bot]

Comment on attachment 212796 [details]
Patch

Clearing flags on attachment: 212796

Committed r157251: <http://trac.webkit.org/changeset/157251>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.