Bug 110029

Summary: [JSC] Remove custom mark function for NamedNodeMap.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarcelo, ggaren, kling, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Andreas Kling
Reported 2013-02-16 13:48:19 PST
NamedNodeMap already keeps its Element owner alive, so we can dump the FIXME and custom visitChildren() in the JSC wrapper.
Attachments
Patch (2.42 KB, patch)
2013-02-16 13:49 PST, Andreas Kling 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-02-16 13:49:12 PST
Created attachment 188728 [details] Patch
Darin Adler
Comment 2 2013-02-16 14:01:06 PST
Comment on attachment 188728 [details] Patch I believe this is no longer needed. But do we have tests that cover it?
Geoffrey Garen
Comment 3 2013-02-16 15:17:23 PST
(In reply to comment #0) > NamedNodeMap already keeps its Element owner alive, so we can dump the FIXME and custom visitChildren() in the JSC wrapper. Has this always been true, or is it a recent change? I'm pretty sure I originally learned about the need for this function the hard way.
Andreas Kling
Comment 4 2013-02-16 15:23:47 PST
(In reply to comment #3) > (In reply to comment #0) > > NamedNodeMap already keeps its Element owner alive, so we can dump the FIXME and custom visitChildren() in the JSC wrapper. > > Has this always been true, or is it a recent change? > > I'm pretty sure I originally learned about the need for this function the hard way. I changed it with https://trac.webkit.org/changeset/104130
Andreas Kling
Comment 5 2013-02-16 15:40:55 PST
(In reply to comment #2) > (From update of attachment 188728 [details]) > I believe this is no longer needed. But do we have tests that cover it? Yup! You added fast/dom/Attr/access-after-element-destruction.html for this issue here: http://trac.webkit.org/changeset/48769 That one also covers Attr node wrappers which are slightly less trivial to fix, but might be worth doing next.
Andreas Kling
Comment 6 2013-02-16 17:04:02 PST
Committed r143118: <http://trac.webkit.org/changeset/143118>
Note You need to log in before you can comment on or make changes to this bug.