Bug 109989

Summary: Autogenerate Settings that call setNeedsRecalcStyleInAllFrames when set
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, philn, rego+ews, rniwa, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Tony Chang
Reported 2013-02-15 17:08:29 PST
Autogenerate Settings that call setNeedsRecalcStyleInAllFrames when set
Attachments
Patch (20.47 KB, patch)
2013-02-15 17:16 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (19.04 KB, patch)
2013-02-20 14:49 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (21.83 KB, patch)
2013-02-20 17:06 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.39 KB, patch)
2013-02-21 13:44 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2013-02-15 17:16:00 PST
Created attachment 188672 [details] Patch
Build Bot
Comment 2 2013-02-17 08:52:50 PST
Comment on attachment 188672 [details] Patch Attachment 188672 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16593871 New failing tests: inspector/styles/stylesheet-tracking.html
Build Bot
Comment 3 2013-02-18 12:04:53 PST
Comment on attachment 188672 [details] Patch Attachment 188672 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16611345
Tony Chang
Comment 4 2013-02-20 14:49:40 PST
Created attachment 189384 [details] Patch
Tony Chang
Comment 5 2013-02-20 14:50:11 PST
rebase and run against the try bots again.
Tony Chang
Comment 6 2013-02-20 17:06:30 PST
Created attachment 189419 [details] Patch
Ryosuke Niwa
Comment 7 2013-02-20 19:34:21 PST
Comment on attachment 189419 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189419&action=review > Source/WebCore/page/Settings.in:36 > +minimumFontSize type=int, initial=0, setNeedsStyleRecalcWhenSetting=1 It's kind of redundant to say "WhenSetting" since this is Settings.in. I would have preferred to communicate the fact we're going to do that in all frames instead. i.e. setNeedsStyleRecalcInAllFrames.
Ryosuke Niwa
Comment 8 2013-02-20 21:48:57 PST
Comment on attachment 189419 [details] Patch r=me with the comment above.
Build Bot
Comment 9 2013-02-21 12:13:09 PST
Comment on attachment 189419 [details] Patch Attachment 189419 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16693233
Tony Chang
Comment 10 2013-02-21 13:44:50 PST
Created attachment 189593 [details] Patch for landing
Tony Chang
Comment 11 2013-02-21 13:45:09 PST
(In reply to comment #7) > (From update of attachment 189419 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=189419&action=review > > > Source/WebCore/page/Settings.in:36 > > +minimumFontSize type=int, initial=0, setNeedsStyleRecalcWhenSetting=1 > > It's kind of redundant to say "WhenSetting" since this is Settings.in. I would have preferred to communicate the fact we're going to do that in all frames instead. > i.e. setNeedsStyleRecalcInAllFrames. Thanks! I renamed to setNeedsStyleRecalcInAllFrames and added the exports for Win.
WebKit Review Bot
Comment 12 2013-02-21 14:23:02 PST
Comment on attachment 189593 [details] Patch for landing Clearing flags on attachment: 189593 Committed r143652: <http://trac.webkit.org/changeset/143652>
WebKit Review Bot
Comment 13 2013-02-21 14:23:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.