Summary: | feFlood incorrectly applied color-interpolation-filters | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephen Chenney <schenney> | ||||||||
Component: | SVG | Assignee: | Stephen Chenney <schenney> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, krit, rniwa, senorblanco, webkit.review.bot, zimmermann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 105929 | ||||||||||
Attachments: |
|
Created attachment 188714 [details]
Patch
Comment on attachment 188714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188714&action=review This looks reasonable to me, but I'll leave for one of the SVG peeps. > Source/WebCore/platform/graphics/filters/FEFlood.cpp:81 > + // feFlood does not color interpolation of any kind, so the result is always in ColorSpaceDeviceRGB regardless of Nit: This sentence no verb. Comment on attachment 188714 [details]
Patch
LGTM. r=me.
Created attachment 188719 [details]
Patch
Adding linux expectations. Will add Mac expectations too before commit.
Comment on attachment 188719 [details] Patch Clearing flags on attachment: 188719 Committed r143267: <http://trac.webkit.org/changeset/143267> All reviewed patches have been landed. Closing bug. Are you going to rebaseline results on Mac port? If not, then I'm just going to delete ImageOnlyFailures expectations added by this patch. (In reply to comment #7) > Are you going to rebaseline results on Mac port? If not, then I'm just going to delete ImageOnlyFailures expectations added by this patch. I was just going to delete the expectations, as it seems the tests are passing without any rebaselines for Mac. |
Created attachment 188665 [details] Test case. Open the attached file in a WebKit browser (Chrome at least) and note that the greys are two different shades. In Opera and Firefox they are the same darker shade. That's because we are apparently applying color-interpolation-filters to feFlood, even though it does no interpolation at all. We should just be taking the sRGB specified (50%,50%,50%) color and applying it in sRGB (the default color space for all filter ops).