Summary: | Hide MainResourceLoader from the outside world | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nate Chapin <japhet> | ||||
Component: | WebCore Misc. | Assignee: | Nate Chapin <japhet> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric.carlson, esprehn+autocc, feature-media-reviews, gyuyoung.kim, jer.noble, mifenton, ojan.autocc, rakuco, rwlbuis, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 104969 | ||||||
Attachments: |
|
Description
Nate Chapin
2013-02-15 14:12:21 PST
Created attachment 193195 [details]
patch
Comment on attachment 193195 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=193195&action=review > Source/WebCore/loader/DocumentLoader.cpp:126 > +ResourceLoader* DocumentLoader::mainResourceLoader() const > +{ > + return m_mainResourceLoader ? m_mainResourceLoader->loader() : 0; > +} Nate tells me this slight nuttiness is going to be short-lived. (In reply to comment #2) > (From update of attachment 193195 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=193195&action=review > > > Source/WebCore/loader/DocumentLoader.cpp:126 > > +ResourceLoader* DocumentLoader::mainResourceLoader() const > > +{ > > + return m_mainResourceLoader ? m_mainResourceLoader->loader() : 0; > > +} > > Nate tells me this slight nuttiness is going to be short-lived. Yeah, sadly it has going to be there temporarily unless I did this merger as a 150KB monster patch. Hopefully a week or less, we'll see. Comment on attachment 193195 [details] patch Clearing flags on attachment: 193195 Committed r145914: <http://trac.webkit.org/changeset/145914> All reviewed patches have been landed. Closing bug. |