Bug 109965

Summary:

Rebaseline layout tests after 109302

Product:

WebKit

Reporter:

Glenn Hartmann <hartmanng>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

dglazkov, eric, ojan.autocc, simon.fraser, vollick, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

109302

Bug Blocks:

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-

Glenn Hartmann

Reported 2013-02-15 13:18:00 PST

A few layout tests are broken due to more liberal opting in of composited scrolling in overflow divs.

Attachments
Patch (222.33 KB, patch) 2013-02-19 09:55 PST, Glenn Hartmann	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Glenn Hartmann

Comment 1 2013-02-19 09:55:28 PST

Created attachment 189107 [details] Patch Contains code from https://bugs.webkit.org/show_bug.cgi?id=109302, will rebaseline when 109302 lands.

WebKit Review Bot

Comment 2 2013-02-19 09:58:13 PST

Attachment 189107 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-expected.txt', u'LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html', u'LayoutTests/compositing/overflow/opt-into-composited-scrolling-positioned-ancestor-expected.txt', u'LayoutTests/compositing/overflow/opt-into-composited-scrolling-positioned-ancestor.html', u'LayoutTests/compositing/overflow/textarea-scroll-touch-expected.txt', u'LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png', u'LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h']" exit_code: 1 LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2013-02-19 15:56:46 PST

Comment on attachment 189107 [details] Patch Attachment 189107 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16635103 New failing tests: platform/chromium/virtual/gpu/compositedscrolling/scrollbars/overflow-scrollbar-combinations.html

Note You need to log in before you can comment on or make changes to this bug.