| Summary: | [GTK] Spread the gyp build files throughout the tree | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
| Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dpranke, gustavo, pnormand | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 109969 | ||||||
| Attachments: |
|
||||||
|
Description
Martin Robinson
2013-02-15 12:19:32 PST
Created attachment 188632 [details]
Patch
Comment on attachment 188632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188632&action=review looks basically fine. As I've mentioned before, I'm not a big fan of the widespread use of relative paths in gyp, and so if I was doing this I'd keep $(Source) around in some form and then derive all of the other variables relative to that. But I can't say for sure that that's definitely a better way to do things; others might disagree. > Source/JavaScriptCore/JavaScriptCore.gyp/generate-derived-sources.sh:14 > +make --no-builtin-rules -f "$JavaScriptCore/DerivedSources.make" JavaScriptCore=$JavaScriptCore hopefully at some point we can get away from needing to call make ... (In reply to comment #2) > > Source/JavaScriptCore/JavaScriptCore.gyp/generate-derived-sources.sh:14 > > +make --no-builtin-rules -f "$JavaScriptCore/DerivedSources.make" JavaScriptCore=$JavaScriptCore > > hopefully at some point we can get away from needing to call make ... Ah, I see you get to this in bug 109969 :) (In reply to comment #2) > (From update of attachment 188632 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188632&action=review > > looks basically fine. As I've mentioned before, I'm not a big fan of the widespread use of relative paths in gyp, and so if I was doing this I'd keep $(Source) around in some form and then derive all of the other variables relative to that. > > But I can't say for sure that that's definitely a better way to do things; others might disagree. I guess you mean in the dependency lines like ../../WTF/WTF.gyp/WTFGTK.gyp:wtf? I can add a Source variable and make those relative to that when landing this. Committed r143093: <http://trac.webkit.org/changeset/143093> |