Bug 109960

Summary: [GTK] Spread the gyp build files throughout the tree
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, gustavo, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109969    
Attachments:
Description Flags
Patch dpranke: review+

Martin Robinson
Reported 2013-02-15 12:19:32 PST
This will make it a lot easier to share pieces of the gyp build with Chromium (and potentially other ports).
Attachments
Patch (17.67 KB, patch)
2013-02-15 13:26 PST, Martin Robinson
dpranke: review+
Martin Robinson
Comment 1 2013-02-15 13:26:39 PST
Dirk Pranke
Comment 2 2013-02-15 17:37:31 PST
Comment on attachment 188632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188632&action=review looks basically fine. As I've mentioned before, I'm not a big fan of the widespread use of relative paths in gyp, and so if I was doing this I'd keep $(Source) around in some form and then derive all of the other variables relative to that. But I can't say for sure that that's definitely a better way to do things; others might disagree. > Source/JavaScriptCore/JavaScriptCore.gyp/generate-derived-sources.sh:14 > +make --no-builtin-rules -f "$JavaScriptCore/DerivedSources.make" JavaScriptCore=$JavaScriptCore hopefully at some point we can get away from needing to call make ...
Dirk Pranke
Comment 3 2013-02-15 17:39:53 PST
(In reply to comment #2) > > Source/JavaScriptCore/JavaScriptCore.gyp/generate-derived-sources.sh:14 > > +make --no-builtin-rules -f "$JavaScriptCore/DerivedSources.make" JavaScriptCore=$JavaScriptCore > > hopefully at some point we can get away from needing to call make ... Ah, I see you get to this in bug 109969 :)
Martin Robinson
Comment 4 2013-02-15 19:06:26 PST
(In reply to comment #2) > (From update of attachment 188632 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188632&action=review > > looks basically fine. As I've mentioned before, I'm not a big fan of the widespread use of relative paths in gyp, and so if I was doing this I'd keep $(Source) around in some form and then derive all of the other variables relative to that. > > But I can't say for sure that that's definitely a better way to do things; others might disagree. I guess you mean in the dependency lines like ../../WTF/WTF.gyp/WTFGTK.gyp:wtf? I can add a Source variable and make those relative to that when landing this.
Martin Robinson
Comment 5 2013-02-15 19:27:42 PST
Note You need to log in before you can comment on or make changes to this bug.