Bug 109904

Summary: [EFL] Rebaseline failure media tests after r142947
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, eric.carlson, feature-media-reviews, lucas.de.marchi, macpherson, menard, naginenis, ojan.autocc, rakuco, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Gyuyoung Kim 2013-02-15 00:03:01 PST
Rebaseline and gardening some media test cases in EFL TestExpectations.
Comment 1 Gyuyoung Kim 2013-02-15 00:09:38 PST
Created attachment 188495 [details]
Patch
Comment 2 Chris Dumez 2013-02-15 00:11:06 PST
How about the pixel results? We should probably update them too.
Comment 3 Gyuyoung Kim 2013-02-15 00:51:04 PST
Created attachment 188500 [details]
Patch
Comment 4 Chris Dumez 2013-02-15 00:53:33 PST
Comment on attachment 188500 [details]
Patch

The time text does not seems properly vertically aligned. It looks like this may need fixing.
Comment 5 Gyuyoung Kim 2013-02-15 01:07:06 PST
(In reply to comment #4)
> (From update of attachment 188500 [details])
> The time text does not seems properly vertically aligned. It looks like this may need fixing.

Yes, right. thank you for your detail looking.
Comment 6 Gyuyoung Kim 2013-02-15 01:31:23 PST
Created attachment 188510 [details]
Patch
Comment 7 Gyuyoung Kim 2013-02-15 04:12:42 PST
Comment on attachment 188510 [details]
Patch

Need to check a little further.
Comment 8 Gyuyoung Kim 2013-02-15 23:41:55 PST
Created attachment 188697 [details]
Patch
Comment 9 Gyuyoung Kim 2013-02-15 23:43:47 PST
It looks that mediaControlsEfl.css modification doesn't influence on other media test cases when I run layout test on my machine.
Comment 10 Build Bot 2013-02-16 02:26:56 PST
Comment on attachment 188697 [details]
Patch

Attachment 188697 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16545065

New failing tests:
media/video-controls-captions-trackmenu.html
Comment 11 Gyuyoung Kim 2013-02-17 18:30:26 PST
(In reply to comment #10)
> (From update of attachment 188697 [details])
> Attachment 188697 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://queues.webkit.org/results/16545065
> 
> New failing tests:
> media/video-controls-captions-trackmenu.html

Unrelated.
Comment 12 Gyuyoung Kim 2013-02-18 04:14:54 PST
Created attachment 188842 [details]
Patch for landing
Comment 13 WebKit Review Bot 2013-02-18 05:08:24 PST
Comment on attachment 188842 [details]
Patch for landing

Clearing flags on attachment: 188842

Committed r143198: <http://trac.webkit.org/changeset/143198>
Comment 14 WebKit Review Bot 2013-02-18 05:08:29 PST
All reviewed patches have been landed.  Closing bug.