Summary: | [EFL] Rebaseline failure media tests after r142947 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, cdumez, eric.carlson, feature-media-reviews, lucas.de.marchi, macpherson, menard, naginenis, ojan.autocc, rakuco, rniwa, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-02-15 00:03:01 PST
Created attachment 188495 [details]
Patch
How about the pixel results? We should probably update them too. Created attachment 188500 [details]
Patch
Comment on attachment 188500 [details]
Patch
The time text does not seems properly vertically aligned. It looks like this may need fixing.
(In reply to comment #4) > (From update of attachment 188500 [details]) > The time text does not seems properly vertically aligned. It looks like this may need fixing. Yes, right. thank you for your detail looking. Created attachment 188510 [details]
Patch
Comment on attachment 188510 [details]
Patch
Need to check a little further.
Created attachment 188697 [details]
Patch
It looks that mediaControlsEfl.css modification doesn't influence on other media test cases when I run layout test on my machine. Comment on attachment 188697 [details] Patch Attachment 188697 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16545065 New failing tests: media/video-controls-captions-trackmenu.html (In reply to comment #10) > (From update of attachment 188697 [details]) > Attachment 188697 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://queues.webkit.org/results/16545065 > > New failing tests: > media/video-controls-captions-trackmenu.html Unrelated. Created attachment 188842 [details]
Patch for landing
Comment on attachment 188842 [details] Patch for landing Clearing flags on attachment: 188842 Committed r143198: <http://trac.webkit.org/changeset/143198> All reviewed patches have been landed. Closing bug. |